<html> <head> <base href="https://bugs.freedesktop.org/"> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - RFE: absolute mode for logogram input on a touchpad" href="https://bugs.freedesktop.org/show_bug.cgi?id=85879#c8">Comment # 8</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - RFE: absolute mode for logogram input on a touchpad" href="https://bugs.freedesktop.org/show_bug.cgi?id=85879">bug 85879</a> from <a class="email" href="mailto:jadahl@gmail.com" title="Jonas Ådahl <jadahl@gmail.com>"> Jonas Ådahl</a> <pre>Comment on <a href="attachment.cgi?id=124567" name="attach_124567" title="A draft of the interface">attachment 124567</a> <a href="attachment.cgi?id=124567&action=edit" title="A draft of the interface">[details]</a> <a href='page.cgi?id=splinter.html&bug=85879&attachment=124567'>[review]</a> A draft of the interface Review of <a href="attachment.cgi?id=124567" name="attach_124567" title="A draft of the interface">attachment 124567</a> <a href="attachment.cgi?id=124567&action=edit" title="A draft of the interface">[details]</a> <a href='page.cgi?id=splinter.html&bug=85879&attachment=124567'>[review]</a>: ----------------------------------------------------------------- ::: src/libinput.h @@ +541,5 @@ > + * > + * Valid event types for this event are > + * @ref LIBINPUT_EVENT_TOUCHPAD_TOUCH_DOWN, > + * @ref LIBINPUT_EVENT_TOUCHPAD_TOUCH_MOTION, > + * @ref LIBINPUT_EVENT_TOUCHPAD_TOUCH_UP. Any use for a LIBINPUT_EVENT_TOUCHPAD_FRAME event? @@ +543,5 @@ > + * @ref LIBINPUT_EVENT_TOUCHPAD_TOUCH_DOWN, > + * @ref LIBINPUT_EVENT_TOUCHPAD_TOUCH_MOTION, > + * @ref LIBINPUT_EVENT_TOUCHPAD_TOUCH_UP. > + */ > +struct libinput_event_touchpad_touch; Would it maybe be better to just group this as a libinput_event_touchpad event? I can't think of what other events than touch down/move/up, but grouping it under "touchpad" would at least not block us/make it awkward to add some other touchpad specific event. @@ +4954,5 @@ > + * require changing to a neutral state first before activating the new > + * method. > + * > + * Disabling the direct touch mode on a device that does not have a direct > + * touch mode always succeeds. Should it be specified what happens to active gestures (including two finger scroll, and tap) etc? Do they continue, or are they cancelled in some way?</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the assignee for the bug.</li> </ul> </body> </html>