<html>
<head>
<base href="https://bugzilla.gnome.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_REOPENED "
title="REOPENED - wayland: gnome-terminal does not fill entire area when tiled"
href="https://bugzilla.gnome.org/show_bug.cgi?id=755947#c7">Comment # 7</a>
on <a class="bz_bug_link
bz_status_REOPENED "
title="REOPENED - wayland: gnome-terminal does not fill entire area when tiled"
href="https://bugzilla.gnome.org/show_bug.cgi?id=755947">bug 755947</a>
from <span class="vcard"><a href="page.cgi?id=describeuser.html&login=simon.mcvittie%40collabora.co.uk" title="Simon McVittie <simon.mcvittie@collabora.co.uk>"> <span class="fn">Simon McVittie</span></a>
</span></b>
<pre>(In reply to Olivier Fourdan from <a href="show_bug.cgi?id=755947#c5">comment #5</a>)
<span class="quote">> So, FWIW, I agree with this patch but it depends on <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - tiled (snapped, half-maximized) windows in Wayland aren't GDK_WINDOW_STATE_TILED"
href="show_bug.cgi?id=766860">bug 766860</a> on Wayland.</span >
Olivier's patches to signal a simple boolean tiling state through Wayland have
now been applied.
(In reply to Matthias Clasen from <a href="show_bug.cgi?id=755947#c6">comment #6</a>)
<span class="quote">> I agree that this patch will improve things under gnome-shell. But I'd
> caution that 'tiled' does not necessarily imply 'fixed size' - Jasper had a
> prototype for a tiling system that lets you resize tiled windows</span >
Can we apply this one for now, and cross that bridge when we come to it? The
protocol by which GTK on Wayland learns about tiled windows is currently
GTK/Mutter-specific, so this isn't going to hurt anything on non-Mutter
compositors; and it's a rather annoying "papercut" when using half-screen
terminals under Wayland.
If someone adds per-edge "snapped" flags to the Wayland protocol later, we'd
want to change the logic to something like this pseudocode:
if (maximized || fullscreen)
flags |= (EXACT_WIDTH | EXACT_HEIGHT);
if (snapped_left && snapped_right)
flags |= EXACT_WIDTH;
if (snapped_top && snapped_bottom)
flags |= EXACT_HEIGHT;
...
if (flags & EXACT_WIDTH)
use the actual width requested
else
round width down to the next character-cell step
if (flags & EXACT_HEIGHT)
use the actual height requested
else
round height down to the next character-cell step
(That would also require splitting up GDK_HINT_RESIZE_INC into horizontal and
vertical parts, so that gdk_window_constrain_size() can do the right thing.)</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>