<html>
<head>
<base href="https://bugzilla.gnome.org/" />
</head>
<body><span class="vcard"><a href="page.cgi?id=describeuser.html&login=jadahl%40gmail.com" title="Jonas Ådahl <jadahl@gmail.com>"> <span class="fn">Jonas Ådahl</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - CLIPBOARD target request after PRIMARY request times out. GDK_SELECTION_NOTIFY has wrong selection id"
href="https://bugzilla.gnome.org/show_bug.cgi?id=768177">bug 768177</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #330600 status</td>
<td>none
</td>
<td>accepted-commit_now
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - CLIPBOARD target request after PRIMARY request times out. GDK_SELECTION_NOTIFY has wrong selection id"
href="https://bugzilla.gnome.org/show_bug.cgi?id=768177#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - CLIPBOARD target request after PRIMARY request times out. GDK_SELECTION_NOTIFY has wrong selection id"
href="https://bugzilla.gnome.org/show_bug.cgi?id=768177">bug 768177</a>
from <span class="vcard"><a href="page.cgi?id=describeuser.html&login=jadahl%40gmail.com" title="Jonas Ådahl <jadahl@gmail.com>"> <span class="fn">Jonas Ådahl</span></a>
</span></b>
<pre>Review of <span class=""><a href="attachment.cgi?id=330600&action=diff" name="attach_330600" title="wayland: Separate selection buffers and other per-selection atom data">attachment 330600</a> <a href="attachment.cgi?id=330600&action=edit" title="wayland: Separate selection buffers and other per-selection atom data">[details]</a></span> <a href='review?bug=768177&attachment=330600'>[review]</a>:
As far as I can tell, this looks correct to me (with one minor nit).
::: gdk/wayland/gdkselection-wayland.c
@@ +99,3 @@
{
/* Destination-side data */
+ SelectionData selections[3];
nit: Could just as well now add a ATOM_LAST or N_ATOMS to the enum, and use
that instead of the 3s? Makes it more obvious what is in the arrays as well.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>