<html>
<head>
<base href="https://bugzilla.gnome.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - regression in menu positioning on wayland"
href="https://bugzilla.gnome.org/show_bug.cgi?id=769402#c10">Comment # 10</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - regression in menu positioning on wayland"
href="https://bugzilla.gnome.org/show_bug.cgi?id=769402">bug 769402</a>
from <span class="vcard"><a href="page.cgi?id=describeuser.html&login=william%40attente.ca" title="William Hua <william@attente.ca>"> <span class="fn">William Hua</span></a>
</span></b>
<pre>Review of <span class=""><a href="attachment.cgi?id=332693&action=diff" name="attach_332693" title="gdkwindow: Use toplevel for getting root cords in move_to_rect()">attachment 332693</a> <a href="attachment.cgi?id=332693&action=edit" title="gdkwindow: Use toplevel for getting root cords in move_to_rect()">[details]</a></span> <a href='review?bug=769402&attachment=332693'>[review]</a>:
Thanks, just a couple questions, but these patches do fix the problem.
I'm still a bit hesitant to alter the default implementation for the sake of
the Wayland backend, which will have its own implementation at some point. But
if it still needs a lot of work, we can do it to fix the regression. I didn't
see any problems with this patch under X11 or Mir.
::: gdk/gdkwindowimpl.c
@@ +187,3 @@
+ {
+ if (_gdk_window_is_toplevel (window))
+{
Is this needed if we already know window->window_type == GDK_WINDOW_CHILD?
@@ +191,3 @@
+ gdk_window_coords_to_parent (window, xf, yf, &xf, &yf);
+
+ gdouble yf = y;
Should we use gdk_window_get_effective_parent (window) instead?
The docs for gdk_window_coords_to_parent () say that for off-screen windows, it
converts to the window's embedder instead.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>