<html>
<head>
<base href="https://bugzilla.gnome.org/" />
</head>
<body><span class="vcard"><a href="page.cgi?id=describeuser.html&login=william%40attente.ca" title="William Hua <william@attente.ca>"> <span class="fn">William Hua</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - regression in menu positioning on wayland"
href="https://bugzilla.gnome.org/show_bug.cgi?id=769402">bug 769402</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #332910 status</td>
<td>none
</td>
<td>accepted-commit_now
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - regression in menu positioning on wayland"
href="https://bugzilla.gnome.org/show_bug.cgi?id=769402#c14">Comment # 14</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - regression in menu positioning on wayland"
href="https://bugzilla.gnome.org/show_bug.cgi?id=769402">bug 769402</a>
from <span class="vcard"><a href="page.cgi?id=describeuser.html&login=william%40attente.ca" title="William Hua <william@attente.ca>"> <span class="fn">William Hua</span></a>
</span></b>
<pre>Review of <span class=""><a href="attachment.cgi?id=332910&action=diff" name="attach_332910" title="gdkwindow: Use toplevel for getting root cords in move_to_rect()">attachment 332910</a> <a href="attachment.cgi?id=332910&action=edit" title="gdkwindow: Use toplevel for getting root cords in move_to_rect()">[details]</a></span> <a href='review?bug=769402&attachment=332910'>[review]</a>:
Looks good, just remove _gdk_window_is_toplevel () that isn't needed any more.
::: gdk/gdkinternals.h
@@ +545,3 @@
gboolean _gdk_window_has_impl (GdkWindow *window);
GdkWindow * _gdk_window_get_impl_window (GdkWindow *window);
+gboolean _gdk_window_is_toplevel (GdkWindow *window);
This isn't necessary any more.
::: gdk/gdkwindow.c
@@ +666,2 @@
gboolean
+_gdk_window_is_toplevel (GdkWindow *window)
Same with this.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>