<html>
<head>
<base href="https://bugzilla.gnome.org/" />
</head>
<body><span class="vcard"><a href="page.cgi?id=describeuser.html&login=jadahl%40gmail.com" title="Jonas Ådahl <jadahl@gmail.com>"> <span class="fn">Jonas Ådahl</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Wayland: Unmapping a toplevel from a menu/popup can lead to a protocol error"
href="https://bugzilla.gnome.org/show_bug.cgi?id=770906">bug 770906</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #335336 status</td>
<td>none
</td>
<td>accepted-commit_now
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Wayland: Unmapping a toplevel from a menu/popup can lead to a protocol error"
href="https://bugzilla.gnome.org/show_bug.cgi?id=770906#c8">Comment # 8</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Wayland: Unmapping a toplevel from a menu/popup can lead to a protocol error"
href="https://bugzilla.gnome.org/show_bug.cgi?id=770906">bug 770906</a>
from <span class="vcard"><a href="page.cgi?id=describeuser.html&login=jadahl%40gmail.com" title="Jonas Ådahl <jadahl@gmail.com>"> <span class="fn">Jonas Ådahl</span></a>
</span></b>
<pre>Review of <span class=""><a href="attachment.cgi?id=335336&action=diff" name="attach_335336" title="[PATCH] wayland: unmap popup along with its toplevel">attachment 335336</a> <a href="attachment.cgi?id=335336&action=edit" title="[PATCH] wayland: unmap popup along with its toplevel">[details]</a></span> <a href='review?bug=770906&attachment=335336'>[review]</a>:
Looks good; just only one nit below.
::: gdk/wayland/gdkwindow-wayland.c
@@ +2349,3 @@
+ }
+ current_popups = g_list_next (current_popups);
+ }
Just a nit: this is an iterator of a GList. Those usually look like
GList *l;
for (l = ... ; l; l = l->next)
...
so it'd be clearer we just used the same method here as elsewhere. Also no need
to pass the 'current_popups' as a parameter really, as that function will never
be called with anything else.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>