<html> <head> <base href="https://bugzilla.gnome.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - [Wayland] Drop-down menus are broken in position and size on HiDPI screens" href="https://bugzilla.gnome.org/show_bug.cgi?id=771841#c20">Comment # 20</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - [Wayland] Drop-down menus are broken in position and size on HiDPI screens" href="https://bugzilla.gnome.org/show_bug.cgi?id=771841">bug 771841</a> from <a href="page.cgi?id=describeuser.html&login=sjoerd%40luon.net" title="Sjoerd Simons <sjoerd@luon.net>"> Sjoerd Simons</a> <pre>(In reply to Jonas Ådahl from <a href="show_bug.cgi?id=771841#c19">comment #19</a>) > (In reply to Sjoerd Simons from <a href="show_bug.cgi?id=771841#c16">comment #16</a>) > > Review of <a href="attachment.cgi?id=336172&action=diff" name="attach_336172" title="wayland/xdg-popup: Force monitor of the top-level">attachment 336172</a> <a href="attachment.cgi?id=336172&action=edit" title="wayland/xdg-popup: Force monitor of the top-level">[details]</a> <a href='review?bug=771841&attachment=336172'>[review]</a> [review] [review]: > > > > The initial case block doesn't actually happen as _meta_window_shared_new > > will set the initial monitor via meta_screen_calculate_monitor_for_window, > > which means from is never NULL. So the first round through this function > > actually has from != to. The problem this patch avoids is not syncing the > > popup monitor to the top-level monitor as the scaled_new monitor doesn't > > match the top-level monitor. > > Ah, I see. I guess we can go with that approach then, and fix it properly > after I've reworked how MetaWindow's are constructed. Could you commit these in that case ;). Would be great to have that sorted in git</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are on the CC list for the bug.</li> </ul> </body> </html>