<html>
<head>
<base href="https://bugzilla.gnome.org/" />
</head>
<body><span class="vcard"><a href="page.cgi?id=describeuser.html&login=jadahl%40gmail.com" title="Jonas Ådahl <jadahl@gmail.com>"> <span class="fn">Jonas Ådahl</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [Wayland] Maps widget is displayed at wrong position inside gnome-contacts"
href="https://bugzilla.gnome.org/show_bug.cgi?id=771320">bug 771320</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #337315 status</td>
<td>none
</td>
<td>reviewed
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [Wayland] Maps widget is displayed at wrong position inside gnome-contacts"
href="https://bugzilla.gnome.org/show_bug.cgi?id=771320#c11">Comment # 11</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [Wayland] Maps widget is displayed at wrong position inside gnome-contacts"
href="https://bugzilla.gnome.org/show_bug.cgi?id=771320">bug 771320</a>
from <span class="vcard"><a href="page.cgi?id=describeuser.html&login=jadahl%40gmail.com" title="Jonas Ådahl <jadahl@gmail.com>"> <span class="fn">Jonas Ådahl</span></a>
</span></b>
<pre>Review of <span class=""><a href="attachment.cgi?id=337315&action=diff" name="attach_337315" title="[PATCH] gdkwindow: configure native windows in move_native_children()">attachment 337315</a> <a href="attachment.cgi?id=337315&action=edit" title="[PATCH] gdkwindow: configure native windows in move_native_children()">[details]</a></span> <a href='review?bug=771320&attachment=337315'>[review]</a>:
::: gdk/gdkwindow.c
@@ +5989,3 @@
+
+ display = gdk_window_get_display (window);
+ gdk_display_put_event (display, event);
Can be just "gdk_event_put (event);" since you do pretty much what that
function does here.
@@ +6013,3 @@
+ {
+ configure_native_child (child);
+ move_native_children (child);
Can fix the coding style issue (double space) while at it.
@@ +6102,3 @@
window->width, window->height);
}
+ else
How come this is needed? Shouldn't we still skip moving if the absolute
position didn't change?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>