<html>
<head>
<base href="https://bugzilla.gnome.org/" />
</head>
<body><span class="vcard"><a href="page.cgi?id=describeuser.html&login=ofourdan%40redhat.com" title="Olivier Fourdan <ofourdan@redhat.com>"> <span class="fn">Olivier Fourdan</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [Wayland] Maps widget is displayed at wrong position inside gnome-contacts"
href="https://bugzilla.gnome.org/show_bug.cgi?id=771320">bug 771320</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #337315 status</td>
<td>reviewed
</td>
<td>none
</td>
</tr>
<tr>
<td style="text-align:right;">Attachment #337315 is obsolete</td>
<td>
</td>
<td>1
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [Wayland] Maps widget is displayed at wrong position inside gnome-contacts"
href="https://bugzilla.gnome.org/show_bug.cgi?id=771320#c12">Comment # 12</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [Wayland] Maps widget is displayed at wrong position inside gnome-contacts"
href="https://bugzilla.gnome.org/show_bug.cgi?id=771320">bug 771320</a>
from <span class="vcard"><a href="page.cgi?id=describeuser.html&login=ofourdan%40redhat.com" title="Olivier Fourdan <ofourdan@redhat.com>"> <span class="fn">Olivier Fourdan</span></a>
</span></b>
<pre>Created <span class=""><a href="attachment.cgi?id=337492&action=diff" name="attach_337492" title="[PATCH v2] gdkwindow: configure native windows in move_native_children()">attachment 337492</a> <a href="attachment.cgi?id=337492&action=edit" title="[PATCH v2] gdkwindow: configure native windows in move_native_children()">[details]</a></span> <a href='review?bug=771320&attachment=337492'>[review]</a>
[PATCH v2] gdkwindow: configure native windows in move_native_children()
(In reply to Jonas Ådahl from <a href="show_bug.cgi?id=771320#c11">comment #11</a>)
<span class="quote">> Review of <span class="bz_obsolete"><a href="attachment.cgi?id=337315&action=diff" name="attach_337315" title="[PATCH] gdkwindow: configure native windows in move_native_children()">attachment 337315</a> <a href="attachment.cgi?id=337315&action=edit" title="[PATCH] gdkwindow: configure native windows in move_native_children()">[details]</a></span> <a href='review?bug=771320&attachment=337315'>[review]</a> [review]:
>
> ::: gdk/gdkwindow.c
> @@ +5989,3 @@
> +
> + display = gdk_window_get_display (window);
> + gdk_display_put_event (display, event);
>
> Can be just "gdk_event_put (event);" since you do pretty much what that
> function does here.</span >
Yeah good idea, and I was leaking the event as well (since it's a copy that
gets added tothe queue, v2 fixes that.
<span class="quote">> @@ +6013,3 @@
> + {
> + configure_native_child (child);
> + move_native_children (child);
>
> Can fix the coding style issue (double space) while at it.</span >
Coding style is correct here, it's just that it uses a tab (8 char) so it shows
weird in the patch. Anyhow, I replaced it with spaces, but there are tabs in
many other places...
<span class="quote">> @@ +6102,3 @@
> window->width, window->height);
> }
> + else
>
> How come this is needed? Shouldn't we still skip moving if the absolute
> position didn't change?</span >
Yes, that's precisely the problem... abs_x/abs_y can be wrong when
transitioning from/to fullscreen/maximized/normal because the shadows and
header bar get added/removed.
You can try by applying the patch and leaving the test as-is, run totem, switch
to maximized back and forth and the clutter-gtk embed widget will be misplaced
(again).</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>