<html>
<head>
<base href="https://bugzilla.gnome.org/" />
</head>
<body><span class="vcard"><a href="page.cgi?id=describeuser.html&login=jadahl%40gmail.com" title="Jonas Ådahl <jadahl@gmail.com>"> <span class="fn">Jonas Ådahl</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [Wayland] Maps widget is displayed at wrong position inside gnome-contacts"
href="https://bugzilla.gnome.org/show_bug.cgi?id=771320">bug 771320</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">CC</td>
<td>
</td>
<td>jadahl@gmail.com
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [Wayland] Maps widget is displayed at wrong position inside gnome-contacts"
href="https://bugzilla.gnome.org/show_bug.cgi?id=771320#c15">Comment # 15</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [Wayland] Maps widget is displayed at wrong position inside gnome-contacts"
href="https://bugzilla.gnome.org/show_bug.cgi?id=771320">bug 771320</a>
from <span class="vcard"><a href="page.cgi?id=describeuser.html&login=jadahl%40gmail.com" title="Jonas Ådahl <jadahl@gmail.com>"> <span class="fn">Jonas Ådahl</span></a>
</span></b>
<pre>(In reply to Olivier Fourdan from <a href="show_bug.cgi?id=771320#c12">comment #12</a>)
<span class="quote">> Created <span class="bz_obsolete"><a href="attachment.cgi?id=337492&action=diff" name="attach_337492" title="[PATCH v2] gdkwindow: configure native windows in move_native_children()">attachment 337492</a> <a href="attachment.cgi?id=337492&action=edit" title="[PATCH v2] gdkwindow: configure native windows in move_native_children()">[details]</a></span> <a href='review?bug=771320&attachment=337492'>[review]</a> [review]
> [PATCH v2] gdkwindow: configure native windows in move_native_children()
>
> (In reply to Jonas Ådahl from <a href="show_bug.cgi?id=771320#c11">comment #11</a>)
> > Review of <span class="bz_obsolete"><a href="attachment.cgi?id=337315&action=diff" name="attach_337315" title="[PATCH] gdkwindow: configure native windows in move_native_children()">attachment 337315</a> <a href="attachment.cgi?id=337315&action=edit" title="[PATCH] gdkwindow: configure native windows in move_native_children()">[details]</a></span> <a href='review?bug=771320&attachment=337315'>[review]</a> [review] [review]:
> >
> > ::: gdk/gdkwindow.c
> > @@ +5989,3 @@
> > +
> > + display = gdk_window_get_display (window);
> > + gdk_display_put_event (display, event);
> >
> > Can be just "gdk_event_put (event);" since you do pretty much what that
> > function does here.
>
> Yeah good idea, and I was leaking the event as well (since it's a copy that
> gets added tothe queue, v2 fixes that.
>
> > @@ +6013,3 @@
> > + {
> > + configure_native_child (child);
> > + move_native_children (child);
> >
> > Can fix the coding style issue (double space) while at it.
>
> Coding style is correct here, it's just that it uses a tab (8 char) so it
> shows weird in the patch. Anyhow, I replaced it with spaces, but there are
> tabs in many other places...
> </span >
I meant the double space between "move_native_children" and "(child);".
<span class="quote">> > @@ +6102,3 @@
> > window->width, window->height);
> > }
> > + else
> >
> > How come this is needed? Shouldn't we still skip moving if the absolute
> > position didn't change?
>
> Yes, that's precisely the problem... abs_x/abs_y can be wrong when
> transitioning from/to fullscreen/maximized/normal because the shadows and
> header bar get added/removed.</span >
Ah, and at the time, the abs changes, the size hasn't caught up. I guess we
could add 'did-things-change' guards (i.e. check whether the size actually
changed before configuring) but I guess it doesn't hurt that much to let the
callee do that.
I wonder if we can change this in gtk+4 so that 'configure' and gdkwindow's
'size' is always without shadow, then let the shadow expand the backing
wl_surface size some other way, so we don't have all these races.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>