<html>
<head>
<base href="https://bugzilla.gnome.org/" />
</head>
<body><span class="vcard"><a href="page.cgi?id=describeuser.html&login=tiagomatos%40gmail.com" title="Rui Matos <tiagomatos@gmail.com>"> <span class="fn">Rui Matos</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [WAYLAND] random loss of focus on toplevel when mapping/unmapping grab-less xdg_popup"
href="https://bugzilla.gnome.org/show_bug.cgi?id=773210">bug 773210</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #338086 status</td>
<td>none
</td>
<td>reviewed
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [WAYLAND] random loss of focus on toplevel when mapping/unmapping grab-less xdg_popup"
href="https://bugzilla.gnome.org/show_bug.cgi?id=773210#c9">Comment # 9</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [WAYLAND] random loss of focus on toplevel when mapping/unmapping grab-less xdg_popup"
href="https://bugzilla.gnome.org/show_bug.cgi?id=773210">bug 773210</a>
from <span class="vcard"><a href="page.cgi?id=describeuser.html&login=tiagomatos%40gmail.com" title="Rui Matos <tiagomatos@gmail.com>"> <span class="fn">Rui Matos</span></a>
</span></b>
<pre>Review of <span class=""><a href="attachment.cgi?id=338086&action=diff" name="attach_338086" title="[PATCH v3] wayland: Force grab-less xdg_popup on top">attachment 338086</a> <a href="attachment.cgi?id=338086&action=edit" title="[PATCH v3] wayland: Force grab-less xdg_popup on top">[details]</a></span> <a href='review?bug=773210&attachment=338086'>[review]</a>:
Honestly, I'd prefer to just delete the code in meta_window_show() that calls
meta_display_focus_the_no_focus_window() instead of using a weakly defined
window type for these popups.
I just can't think of any case where it makes sense for a new window to cause
us to globally unset focus. Anyone can?
::: src/core/window.c
@@ +7807,3 @@
*/
+ if (window->override_redirect ||
+ window->type == META_WINDOW_OVERRIDE_OTHER)
This should in any case be a separate patch since it's a different issue, and
check for any of the OR window types, not just this one.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>