<html>
<head>
<base href="https://bugzilla.gnome.org/" />
</head>
<body><span class="vcard"><a href="page.cgi?id=describeuser.html&login=tiagomatos%40gmail.com" title="Rui Matos <tiagomatos@gmail.com>"> <span class="fn">Rui Matos</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [WAYLAND] random loss of focus on toplevel when mapping/unmapping grab-less xdg_popup"
href="https://bugzilla.gnome.org/show_bug.cgi?id=773210">bug 773210</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #338386 status</td>
<td>none
</td>
<td>reviewed
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [WAYLAND] random loss of focus on toplevel when mapping/unmapping grab-less xdg_popup"
href="https://bugzilla.gnome.org/show_bug.cgi?id=773210#c13">Comment # 13</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [WAYLAND] random loss of focus on toplevel when mapping/unmapping grab-less xdg_popup"
href="https://bugzilla.gnome.org/show_bug.cgi?id=773210">bug 773210</a>
from <span class="vcard"><a href="page.cgi?id=describeuser.html&login=tiagomatos%40gmail.com" title="Rui Matos <tiagomatos@gmail.com>"> <span class="fn">Rui Matos</span></a>
</span></b>
<pre>Review of <span class=""><a href="attachment.cgi?id=338386&action=diff" name="attach_338386" title="[PATCH 2/2] window: do not focus on ungrab for o-r like windows">attachment 338386</a> <a href="attachment.cgi?id=338386&action=edit" title="[PATCH 2/2] window: do not focus on ungrab for o-r like windows">[details]</a></span> <a href='review?bug=773210&attachment=338386'>[review]</a>:
There is no "ungrab" event, this function is handling "ungrabbed" events, i.e.
events for which there's no explicit grab (display->grab_op ==
META_GRAB_OP_NONE) but still come through mutter because either we're a wayland
compositor or mutter has a passive button grab on the window because it was
unfocused (we need that grab to be able to get an event on X to focus the
window if users click it).
So, thinking a bit more about this, it seems that we should instead be handling
these wayland windows that don't want keyboard focus in the wayland vfunc
meta_window_wayland_focus() and leave the generic code here as is.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>