<html>
<head>
<base href="https://bugzilla.gnome.org/" />
</head>
<body><span class="vcard"><a href="page.cgi?id=describeuser.html&login=tiagomatos%40gmail.com" title="Rui Matos <tiagomatos@gmail.com>"> <span class="fn">Rui Matos</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [WAYLAND] random loss of focus on toplevel when mapping/unmapping grab-less xdg_popup"
href="https://bugzilla.gnome.org/show_bug.cgi?id=773210">bug 773210</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #338400 status</td>
<td>none
</td>
<td>accepted-commit_now
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [WAYLAND] random loss of focus on toplevel when mapping/unmapping grab-less xdg_popup"
href="https://bugzilla.gnome.org/show_bug.cgi?id=773210#c15">Comment # 15</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [WAYLAND] random loss of focus on toplevel when mapping/unmapping grab-less xdg_popup"
href="https://bugzilla.gnome.org/show_bug.cgi?id=773210">bug 773210</a>
from <span class="vcard"><a href="page.cgi?id=describeuser.html&login=tiagomatos%40gmail.com" title="Rui Matos <tiagomatos@gmail.com>"> <span class="fn">Rui Matos</span></a>
</span></b>
<pre>Review of <span class=""><a href="attachment.cgi?id=338400&action=diff" name="attach_338400" title="[PATCH 2/2] wayland: do not focus o-r like windows">attachment 338400</a> <a href="attachment.cgi?id=338400&action=edit" title="[PATCH 2/2] wayland: do not focus o-r like windows">[details]</a></span> <a href='review?bug=773210&attachment=338400'>[review]</a>:
ok, but IMO the commit message should be less about X11 and OR window semantics
and more like what Jonas says in
<a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - GtkSourceView completion popup window not shown, no grabbed seat found"
href="show_bug.cgi?id=771694#c24">https://bugzilla.gnome.org/show_bug.cgi?id=771694#c24</a>
::: src/wayland/meta-window-wayland.c
@@ +139,3 @@
guint32 timestamp)
{
+ if (is_like_override_redirect (window))
maybe rename this to something like should_get_input_focus() ?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>