<html>
<head>
<base href="https://bugzilla.gnome.org/" />
</head>
<body><span class="vcard"><a href="page.cgi?id=describeuser.html&login=rstrode%40redhat.com" title="Ray Strode [halfline] <rstrode@redhat.com>"> <span class="fn">Ray Strode [halfline]</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [Wayland] Crash under gdk_wayland_window_attach_image()"
href="https://bugzilla.gnome.org/show_bug.cgi?id=773274">bug 773274</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #338945 status</td>
<td>reviewed
</td>
<td>accepted-commit_now
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [Wayland] Crash under gdk_wayland_window_attach_image()"
href="https://bugzilla.gnome.org/show_bug.cgi?id=773274#c22">Comment # 22</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [Wayland] Crash under gdk_wayland_window_attach_image()"
href="https://bugzilla.gnome.org/show_bug.cgi?id=773274">bug 773274</a>
from <span class="vcard"><a href="page.cgi?id=describeuser.html&login=rstrode%40redhat.com" title="Ray Strode [halfline] <rstrode@redhat.com>"> <span class="fn">Ray Strode [halfline]</span></a>
</span></b>
<pre>Review of <span class=""><a href="attachment.cgi?id=338945&action=diff" name="attach_338945" title="[PATCH] wayland: check valid pending cairo surface">attachment 338945</a> <a href="attachment.cgi?id=338945&action=edit" title="[PATCH] wayland: check valid pending cairo surface">[details]</a></span> <a href='review?bug=773274&attachment=338945'>[review]</a>:
You write "doesn't check if the drop_cairo_surfaces" but I think you mean the
"staging_cairo_surface". But also, I wish the commit message went into the
specific problem a little bit. Maybe something like
"gdk_wayland_window_attach_image is normally called from gdk_window_end_paint
to notify the compositor of newly staged drawing. If any of the drawing code
inadvertently dispatches the wayland event loop (for instance with a gdk_flush
call), then it's possible that by the time gdk_window_end_paint is called, the
staged drawing is already destroyed. This commit bypasses the attach_image
call in scenarios where the staged drawing is prematurely dropped"</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>