<html>
<head>
<base href="https://bugzilla.gnome.org/" />
</head>
<body><span class="vcard"><a href="page.cgi?id=describeuser.html&login=ebassi%40gmail.com" title="Emmanuele Bassi (:ebassi) <ebassi@gmail.com>"> <span class="fn">Emmanuele Bassi (:ebassi)</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - On Wayland, application containing GtkGLArea stops responding if it's not on current workspace"
href="https://bugzilla.gnome.org/show_bug.cgi?id=769835">bug 769835</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #342424 status</td>
<td>none
</td>
<td>needs-work
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - On Wayland, application containing GtkGLArea stops responding if it's not on current workspace"
href="https://bugzilla.gnome.org/show_bug.cgi?id=769835#c20">Comment # 20</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - On Wayland, application containing GtkGLArea stops responding if it's not on current workspace"
href="https://bugzilla.gnome.org/show_bug.cgi?id=769835">bug 769835</a>
from <span class="vcard"><a href="page.cgi?id=describeuser.html&login=ebassi%40gmail.com" title="Emmanuele Bassi (:ebassi) <ebassi@gmail.com>"> <span class="fn">Emmanuele Bassi (:ebassi)</span></a>
</span></b>
<pre>Review of <span class=""><a href="attachment.cgi?id=342424&action=diff" name="attach_342424" title="wayland: Disable EGL swap interval">attachment 342424</a> <a href="attachment.cgi?id=342424&action=edit" title="wayland: Disable EGL swap interval">[details]</a></span> <a href='review?bug=769835&attachment=342424'>[review]</a>:
Looks definitely better.
::: gdk/wayland/gdkglcontext-wayland.c
@@ +472,3 @@
+ EGL_MIN_SWAP_INTERVAL,
+ &display_wayland->egl_min_swap_interval))
+ return NULL;
You should set the GError if you return NULL here.
Something like:
if (!eglGetConfigAttrib (...))
{
g_set_error_literal (error, GDK_GL_ERROR, GDK_GL_ERROR_NOT_AVAILABLE,
"Could not retrieve the minimum swap interval");
return NULL;
}
But maybe we should move this check inside find_eglconfig_for_window().
@@ +552,3 @@
+ eglSwapInterval (display_wayland->egl_display, 0);
+ else
+ g_warning ("Can't disable GL swap interval");
I'd probably use g_debug(), not a warning.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>