<html> <head> <base href="https://bugzilla.gnome.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - Key repeat under wayland behaves differently, making keyboard navigation e.g. in vim annoyingly unreliable" href="https://bugzilla.gnome.org/show_bug.cgi?id=778019#c4">Comment # 4</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - Key repeat under wayland behaves differently, making keyboard navigation e.g. in vim annoyingly unreliable" href="https://bugzilla.gnome.org/show_bug.cgi?id=778019">bug 778019</a> from <a href="page.cgi?id=describeuser.html&login=ofourdan%40redhat.com" title="Olivier Fourdan <ofourdan@redhat.com>"> Olivier Fourdan</a> <pre>(In reply to Carlos Garnacho from <a href="show_bug.cgi?id=778019#c3">comment #3</a>) > Review of <a href="attachment.cgi?id=344764&action=diff" name="attach_344764" title="[PATCH] wayland: do not cancel key repeat on key press">attachment 344764</a> <a href="attachment.cgi?id=344764&action=edit" title="[PATCH] wayland: do not cancel key repeat on key press">[details]</a> <a href='review?bug=778019&attachment=344764'>[review]</a> [review]: > > Looks good! just a minor comment, feel free to push after fixing. > > ::: gdk/wayland/gdkdevice-wayland.c > @@ +2154,1 @@ > seat->repeat_count++; > > This should probably only happen if state!=0, not that it matters much in > practice, since we just ever check for repeat_count == 1. Err nope, if we do repeat_count++ only on key press (i.e. state != 0) we don't get the expected behavior, the repeat pauses twice.</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are on the CC list for the bug.</li> </ul> </body> </html>