<html> <head> <base href="https://bugs.freedesktop.org/"> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - Skype crashes XWayland which kills GNOME session" href="https://bugs.freedesktop.org/show_bug.cgi?id=100040#c8">Comment # 8</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - Skype crashes XWayland which kills GNOME session" href="https://bugs.freedesktop.org/show_bug.cgi?id=100040">bug 100040</a> from <a class="email" href="mailto:michel@daenzer.net" title="Michel Dänzer <michel@daenzer.net>"> Michel Dänzer</a> <pre>(In reply to Mark B from <a href="show_bug.cgi?id=100040#c7">comment #7</a>) > When I look at the new patch I see that the clientGone test has been removed > from sync_callback() compared to the original patch. That's good to prove > the new changes still address the issue but personally I would be more at > ease if that clientGone check was still included for the final release > patch. It's a one-liner check, costs nothing, and assures ultimate > protection. Not really. The check could only make any difference if xwl_auth_state_client_callback fails to cancel the sync callback before the client is destroyed. In which case, the memory pointed to by state->client may already have been freed or reclaimed for a different client, so the client->clientGone value cannot be relied on anymore.</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the assignee for the bug.</li> </ul> </body> </html>