<html>
    <head>
      <base href="https://bugzilla.gnome.org/" />
    </head>
    <body><table border="1" cellspacing="0" cellpadding="8">
        <tr>
          <th>Bug ID</th>
          <td><a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - Key repeat cancel under Wayland should depend on which key is repeating"
   href="https://bugzilla.gnome.org/show_bug.cgi?id=781285">781285</a>
          </td>
        </tr>

        <tr>
          <th>Summary</th>
          <td>Key repeat cancel under Wayland should depend on which key is repeating
          </td>
        </tr>

        <tr>
          <th>Classification</th>
          <td>Platform
          </td>
        </tr>

        <tr>
          <th>Product</th>
          <td>gtk+
          </td>
        </tr>

        <tr>
          <th>Version</th>
          <td>3.22.x
          </td>
        </tr>

        <tr>
          <th>OS</th>
          <td>Linux
          </td>
        </tr>

        <tr>
          <th>Status</th>
          <td>NEW
          </td>
        </tr>

        <tr>
          <th>Severity</th>
          <td>normal
          </td>
        </tr>

        <tr>
          <th>Priority</th>
          <td>Normal
          </td>
        </tr>

        <tr>
          <th>Component</th>
          <td>Backend: Wayland
          </td>
        </tr>

        <tr>
          <th>Assignee</th>
          <td>gtk-bugs@gtk.org
          </td>
        </tr>

        <tr>
          <th>Reporter</th>
          <td>dant@pnym.net
          </td>
        </tr>

        <tr>
          <th>QA Contact</th>
          <td>gtk-bugs@gtk.org
          </td>
        </tr>

        <tr>
          <th>CC</th>
          <td>rob@robster.org.uk, wayland-bugs@lists.freedesktop.org
          </td>
        </tr>

        <tr>
          <th>GNOME version</th>
          <td>---
          </td>
        </tr></table>
      <p>
        <div>
        <pre>Created <span class=""><a href="attachment.cgi?id=349836&action=diff" name="attach_349836" title="[PATCH] wayland: selectively cancel key repeat on key release">attachment 349836</a> <a href="attachment.cgi?id=349836&action=edit" title="[PATCH] wayland: selectively cancel key repeat on key release">[details]</a></span> <a href='review?bug=781285&attachment=349836'>[review]</a>
[PATCH] wayland: selectively cancel key repeat on key release

Under Wayland, when multiple keys are pressed and the user releases a key, key
repeat should continue unless the key released is the one currently repeating.

In the case of:

- key1 press
- key1 repeat
- key2 press -> key1 repeat stopped
- key2 repeats
- key2 release

The behavior should be to cancel keyboard repeat, though key1 is still held
down. This is consistent with prior X11/XWayland behavior.

The following also must work:

- key1 press
- key2 press
- key2 release
- key2 press
- key1 release
- key2 should continue to repeat

The fix for <a class="bz_bug_link 
          bz_status_RESOLVED  bz_closed"
   title="RESOLVED FIXED - Key repeat under wayland behaves differently, making keyboard navigation e.g. in vim annoyingly unreliable"
   href="show_bug.cgi?id=778019">bug #778019</a> should continue to work:

- key1 press
- key1 repeat
- key2 press -> key1 repeat stopped
- key1 release
- key2 should repeat

The choice to change the counter nkeys to the flag repeat_active helps to solve
the second test case.

Attached is a proposed patch to fix this behavior.</pre>
        </div>
      </p>
      <hr>
      <span>You are receiving this mail because:</span>
      
      <ul>
          <li>You are on the CC list for the bug.</li>
      </ul>
    </body>
</html>