<html>
<head>
<base href="https://bugzilla.gnome.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Key repeat cancel under Wayland should depend on which key is repeating"
href="https://bugzilla.gnome.org/show_bug.cgi?id=781285#c9">Comment # 9</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Key repeat cancel under Wayland should depend on which key is repeating"
href="https://bugzilla.gnome.org/show_bug.cgi?id=781285">bug 781285</a>
from <span class="vcard"><a href="page.cgi?id=describeuser.html&login=dant%40pnym.net" title="Dan Torop <dant@pnym.net>"> <span class="fn">Dan Torop</span></a>
</span></b>
<pre>(In reply to Olivier Fourdan from <a href="show_bug.cgi?id=781285#c8">comment #8</a>)
<span class="quote">> Created <span class=""><a href="attachment.cgi?id=351063&action=diff" name="attach_351063" title="[PATCH v4] wayland: selectively cancel key repeat on key release">attachment 351063</a> <a href="attachment.cgi?id=351063&action=edit" title="[PATCH v4] wayland: selectively cancel key repeat on key release">[details]</a></span> <a href='review?bug=781285&attachment=351063'>[review]</a> [review]
> [PATCH v4] wayland: selectively cancel key repeat on key release
>
> Ok, last try and then I put it at rest, promise...
>
> My take is that we don't even need a "repeat_key" flag, we could simply use
> the existing seat->repeat_key for that, as 0 is not a valid value there.</span >
Hi Olivier,
The last version <span class=""><a href="attachment.cgi?id=351063&action=diff" name="attach_351063" title="[PATCH v4] wayland: selectively cancel key repeat on key release">attachment 351063</a> <a href="attachment.cgi?id=351063&action=edit" title="[PATCH v4] wayland: selectively cancel key repeat on key release">[details]</a></span> <a href='review?bug=781285&attachment=351063'>[review]</a> looks pretty ideal! (Excepting my somewhat
verbose commit message...). It fixes all the test cases for this bug, as well
as taking care of the original darktable issue which brought me to this.
With regards,
Dan</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>