<html>
<head>
<base href="https://bugzilla.gnome.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - wayland: Add possibility to get the exported handle multiple times"
href="https://bugzilla.gnome.org/show_bug.cgi?id=782325#c5">Comment # 5</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - wayland: Add possibility to get the exported handle multiple times"
href="https://bugzilla.gnome.org/show_bug.cgi?id=782325">bug 782325</a>
from <span class="vcard"><a href="page.cgi?id=describeuser.html&login=jadahl%40gmail.com" title="Jonas Ådahl <jadahl@gmail.com>"> <span class="fn">Jonas Ådahl</span></a>
</span></b>
<pre>(In reply to Matthias Clasen from <a href="show_bug.cgi?id=782325#c3">comment #3</a>)
<span class="quote">> Review of <span class=""><a href="attachment.cgi?id=351349&action=diff" name="attach_351349" title="GdkWaylandWindow: Allow calling export() multiple time">attachment 351349</a> <a href="attachment.cgi?id=351349&action=edit" title="GdkWaylandWindow: Allow calling export() multiple time">[details]</a></span> <a href='review?bug=782325&attachment=351349'>[review]</a> [review]:
>
> ::: gdk/wayland/gdkwindow-wayland.c
> @@ +4184,2 @@
> + if (impl->exported.handle && !impl->exported.idle_source_id)
> + impl->exported.idle_source_id = g_idle_add (exported_idle, window);
>
> Do we need to do something about a possibly still pending idle when the
> window is finalized ?
>
> I see we call gdk_wayland_window_unexport in finalize, but that doesn't seem
> to touch the idle</span >
Yepp. Need to remove it. I'll update the patch.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>