<html>
<head>
<base href="https://bugzilla.gnome.org/" />
</head>
<body><span class="vcard"><a href="page.cgi?id=describeuser.html&login=florian.muellner%40gmail.com" title="Florian Müllner <florian.muellner@gmail.com>"> <span class="fn">Florian Müllner</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Shell search provider doesn't work with Wayland"
href="https://bugzilla.gnome.org/show_bug.cgi?id=775099">bug 775099</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #350958 status</td>
<td>none
</td>
<td>reviewed
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Shell search provider doesn't work with Wayland"
href="https://bugzilla.gnome.org/show_bug.cgi?id=775099#c14">Comment # 14</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Shell search provider doesn't work with Wayland"
href="https://bugzilla.gnome.org/show_bug.cgi?id=775099">bug 775099</a>
from <span class="vcard"><a href="page.cgi?id=describeuser.html&login=florian.muellner%40gmail.com" title="Florian Müllner <florian.muellner@gmail.com>"> <span class="fn">Florian Müllner</span></a>
</span></b>
<pre>Review of <span class=""><a href="attachment.cgi?id=350958&action=diff" name="attach_350958" title="remoteSearch: respect "CopyResult" in desktop file">attachment 350958</a> <a href="attachment.cgi?id=350958&action=edit" title="remoteSearch: respect "CopyResult" in desktop file">[details]</a></span> <a href='review?bug=775099&attachment=350958'>[review]</a>:
The commit message is poorly worded - "respect foo property" sounds like there
was a well-established field that we failed to support, rather than something
newly made-up. And of course a search provider keyfile is not a .desktop file
...
::: js/ui/search.js
@@ +184,2 @@
_activateResult: function(result, id) {
this.provider.activateResult(id, this._terms);
Does this make sense, or should we assume that if copyResult is set, then the
app uses the activate-copies pattern?
@@ +185,3 @@
this.provider.activateResult(id, this._terms);
+ if (this.provider.copyResult)
+ this._clipboard.set_text(St.ClipboardType.CLIPBOARD, id);
Of course this doesn't copy the result, but its ID. While I don't know about
any other search provider that uses the activate-copies pattern, this looks
needlessly restrictive.
Maybe something like:
activateResult: function(id, terms) {
if (this.copyResult)
this.proxy.GetResultClipboardTextRemote(id, (text, error) => {
this._clipboard.set_text(St.ClipboardType.CLIPBOARD, text);
});
else
this.proxy.ActivateResultRemote(id, terms,
global.get_current_time());
},</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>