<html>
<head>
<base href="https://bugzilla.gnome.org/" />
</head>
<body><span class="vcard"><a href="page.cgi?id=describeuser.html&login=rishi.is%40lostca.se" title="Debarshi Ray <rishi.is@lostca.se>"> <span class="fn">Debarshi Ray</span></a>
</span> changed
<a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - wayland: do not use g_error() on connection errors"
href="https://bugzilla.gnome.org/show_bug.cgi?id=745289">bug 745289</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #298098 status</td>
<td>none
</td>
<td>committed
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - wayland: do not use g_error() on connection errors"
href="https://bugzilla.gnome.org/show_bug.cgi?id=745289#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - wayland: do not use g_error() on connection errors"
href="https://bugzilla.gnome.org/show_bug.cgi?id=745289">bug 745289</a>
from <span class="vcard"><a href="page.cgi?id=describeuser.html&login=rishi.is%40lostca.se" title="Debarshi Ray <rishi.is@lostca.se>"> <span class="fn">Debarshi Ray</span></a>
</span></b>
<pre>Review of <span class=""><a href="attachment.cgi?id=298098&action=diff" name="attach_298098" title="Updated patch">attachment 298098</a> <a href="attachment.cgi?id=298098&action=edit" title="Updated patch">[details]</a></span> <a href='review?bug=745289&attachment=298098'>[review]</a>:
Looks similar to:
<a href="https://bugzilla.redhat.com/show_bug.cgi?id=1366897">https://bugzilla.redhat.com/show_bug.cgi?id=1366897</a>
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Many apps crash in gdk_event_source_prepare when logging out of GNOME"
href="show_bug.cgi?id=783047">https://bugzilla.gnome.org/show_bug.cgi?id=783047</a>
(updating the patch's status to reflect reality)
::: gdk/wayland/gdkeventsource.c
@@ +164,3 @@
+ {
+ g_warning ("Error %d (%s) dispatching to Wayland display.",
+ errno, g_strerror (errno));
Maybe we should use g_message instead?
See <a href="https://bugzilla.redhat.com/show_bug.cgi?id=1366897#c43">https://bugzilla.redhat.com/show_bug.cgi?id=1366897#c43</a> for a rationale.
The X11 backend (gdk_x_io_error) also uses g_message these days.
@@ +165,3 @@
+ g_warning ("Error %d (%s) dispatching to Wayland display.",
+ errno, g_strerror (errno));
+ exit (1);
Also, maybe, _exit instead?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>