<html>
<head>
<base href="https://bugs.freedesktop.org/">
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEEDINFO "
title="NEEDINFO - Palm detection with TrackPoint buttons"
href="https://bugs.freedesktop.org/show_bug.cgi?id=101574#c10">Comment # 10</a>
on <a class="bz_bug_link
bz_status_NEEDINFO "
title="NEEDINFO - Palm detection with TrackPoint buttons"
href="https://bugs.freedesktop.org/show_bug.cgi?id=101574">bug 101574</a>
from <span class="vcard"><a class="email" href="mailto:peter.hutterer@who-t.net" title="Peter Hutterer <peter.hutterer@who-t.net>"> <span class="fn">Peter Hutterer</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=132395" name="attach_132395" title="patch to add tp_palm_in_edge helper function">attachment 132395</a> <a href="attachment.cgi?id=132395&action=edit" title="patch to add tp_palm_in_edge helper function">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=101574&attachment=132395'>[review]</a>
patch to add tp_palm_in_edge helper function
Review of <span class=""><a href="attachment.cgi?id=132395" name="attach_132395" title="patch to add tp_palm_in_edge helper function">attachment 132395</a> <a href="attachment.cgi?id=132395&action=edit" title="patch to add tp_palm_in_edge helper function">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=101574&attachment=132395'>[review]</a>:
-----------------------------------------------------------------
just one comment on this one, I've changed a few things, will attach the new
patch in a tick
::: src/evdev-mt-touchpad.c
@@ +562,5 @@
<span class="quote">> {
> if (t->state != TOUCH_BEGIN)
> return false;
>
> + if (tp_palm_in_edge(tp, t))</span >
This bit looks definitely buggy: the previous check returned false if it was
*not* in the palm edge area, this one returns false if it's inside the palm
edge area now</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>