<html>
<head>
<base href="https://bugzilla.gnome.org/" />
</head>
<body><span class="vcard"><a href="page.cgi?id=describeuser.html&login=carlosg%40gnome.org" title="Carlos Garnacho <carlosg@gnome.org>"> <span class="fn">Carlos Garnacho</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - In a GNOME Wayland session, gnome-terminal windows cannot be moved around with a wacom pen"
href="https://bugzilla.gnome.org/show_bug.cgi?id=777333">bug 777333</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #354345 status</td>
<td>none
</td>
<td>reviewed
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - In a GNOME Wayland session, gnome-terminal windows cannot be moved around with a wacom pen"
href="https://bugzilla.gnome.org/show_bug.cgi?id=777333#c9">Comment # 9</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - In a GNOME Wayland session, gnome-terminal windows cannot be moved around with a wacom pen"
href="https://bugzilla.gnome.org/show_bug.cgi?id=777333">bug 777333</a>
from <span class="vcard"><a href="page.cgi?id=describeuser.html&login=carlosg%40gnome.org" title="Carlos Garnacho <carlosg@gnome.org>"> <span class="fn">Carlos Garnacho</span></a>
</span></b>
<pre>Review of <span class=""><a href="attachment.cgi?id=354345&action=diff" name="attach_354345" title="Mutter: wayland: Store and retrieve implicit grab information for tablet tools">attachment 354345</a> <a href="attachment.cgi?id=354345&action=edit" title="Mutter: wayland: Store and retrieve implicit grab information for tablet tools">[details]</a></span> <a href='review?bug=777333&attachment=354345'>[review]</a>:
Makes sense, and turns out it's sufficient for window dragging. We still do
need something like MetaWaylandPointerGrabInterface to cater for dnd and
xdg_popup, but probably can be handled separately.
The patch itself looks good! Just a minor comment.
::: src/wayland/meta-wayland-tablet-tool.c
@@ +886,3 @@
+ tool->grab_button = event->button.button;
+ tool->grab_time = clutter_event_get_time (event);
+ tool->grab_serial = wl_display_get_serial
(tool->seat->seat->wl_display);
grab_serial seems unused. You compare with both down_serial and button_serial
on can_grab_surface() which seems right.
Same for grab_button and grab_time, really...</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>