<html> <head> <base href="https://bugzilla.gnome.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - [PATCH] gdk/wayland: allow focusing without a specific timestamp" href="https://bugzilla.gnome.org/show_bug.cgi?id=786455#c4">Comment # 4</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - [PATCH] gdk/wayland: allow focusing without a specific timestamp" href="https://bugzilla.gnome.org/show_bug.cgi?id=786455">bug 786455</a> from <a href="page.cgi?id=describeuser.html&login=carlosg%40gnome.org" title="Carlos Garnacho <carlosg@gnome.org>"> Carlos Garnacho</a> <pre>(In reply to Xiang Fan from <a href="show_bug.cgi?id=786455#c2">comment #2</a>) > (In reply to Matthias Clasen from <a href="show_bug.cgi?id=786455#c1">comment #1</a>) > > this patch doesn't really 'handle' it in any way though, and just passes it > > through, ignoring the comment that it removes > > It's handled in mutter: > <a href="https://git.gnome.org/browse/mutter/tree/src/core/window.c#n3395">https://git.gnome.org/browse/mutter/tree/src/core/window.c#n3395</a> > > Also please look at this commit: > [window: Treat CurrentTime as legal timestamp in activation] > <a href="https://git.gnome.org/browse/mutter/commit/">https://git.gnome.org/browse/mutter/commit/</a> > ?id=5defe574d74eace55bfe9e7e79ffaaa40f50372f > > So IMHO it's safe to consider GDK_CURRENT_TIME valid and just pass it > through. I'd like to point out that mutter figuring out a decent timestamp for the request does not mean that passing GDK_CURRENT_TIME is correct, nor desirable according to the semantics of a "present" request. What would happen here is that the request gets the timestamp at the time Mutter is processing the request, not the time of the input event that triggered the window to be shown. The latter is useful to Mutter to determine whether there was further activity after the present request, the former is a randomly recent timestamp that will beat anything else, and pretty much defeats the purpose of a timestamp in the "present" request.</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are on the CC list for the bug.</li> </ul> </body> </html>