<html>
<head>
<base href="https://bugzilla.gnome.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - gdk_keymap_get_entries_for_keyval() returns TRUE with n_keys=0 in Wayland"
href="https://bugzilla.gnome.org/show_bug.cgi?id=787069#c2">Comment # 2</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - gdk_keymap_get_entries_for_keyval() returns TRUE with n_keys=0 in Wayland"
href="https://bugzilla.gnome.org/show_bug.cgi?id=787069">bug 787069</a>
from <span class="vcard"><a href="page.cgi?id=describeuser.html&login=chpe%40gnome.org" title="Christian Persch <chpe@gnome.org>"> <span class="fn">Christian Persch</span></a>
</span></b>
<pre>Existing code using this may do
if (gdk_keymap_get_entries_for_keyval(..., &keys, &n_keys)) {
/* do something */
g_free(keys);
}
(e.g. firefox does this).
The patch returns FALSE on n_keys == 0, but still keys != NULL, which means a
leak on the code pattern above. Should also change to set return keys = NULL in
this case, I think.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>