<html>
    <head>
      <base href="https://bugzilla.gnome.org/" />
    </head>
    <body><span class="vcard"><a href="page.cgi?id=describeuser.html&login=carlosg%40gnome.org" title="Carlos Garnacho <carlosg@gnome.org>"> <span class="fn">Carlos Garnacho</span></a>
</span> changed
              <a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - [Wayland] Smiley picker attempts to "inhibit shortcuts", results in session-modal dialogue"
   href="https://bugzilla.gnome.org/show_bug.cgi?id=789268">bug 789268</a>
          <br>
             <table border="1" cellspacing="0" cellpadding="8">
          <tr>
            <th>What</th>
            <th>Removed</th>
            <th>Added</th>
          </tr>

         <tr>
           <td style="text-align:right;">CC</td>
           <td>
                
           </td>
           <td>rob@robster.org.uk, wayland-bugs@lists.freedesktop.org
           </td>
         </tr>

         <tr>
           <td style="text-align:right;">Component</td>
           <td>Composer
           </td>
           <td>Backend: Wayland
           </td>
         </tr>

         <tr>
           <td style="text-align:right;">Version</td>
           <td>3.26.x
           </td>
           <td>unspecified
           </td>
         </tr>

         <tr>
           <td style="text-align:right;">Assignee</td>
           <td>evolution-mail-maintainers@gnome.bugs
           </td>
           <td>gtk-bugs@gtk.org
           </td>
         </tr>

         <tr>
           <td style="text-align:right;">Product</td>
           <td>evolution
           </td>
           <td>gtk+
           </td>
         </tr>

         <tr>
           <td style="text-align:right;">QA Contact</td>
           <td>evolution-qa@gnome.bugs
           </td>
           <td>gtk-bugs@gtk.org
           </td>
         </tr></table>
      <p>
        <div>
            <b><a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - [Wayland] Smiley picker attempts to "inhibit shortcuts", results in session-modal dialogue"
   href="https://bugzilla.gnome.org/show_bug.cgi?id=789268#c15">Comment # 15</a>
              on <a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - [Wayland] Smiley picker attempts to "inhibit shortcuts", results in session-modal dialogue"
   href="https://bugzilla.gnome.org/show_bug.cgi?id=789268">bug 789268</a>
              from <span class="vcard"><a href="page.cgi?id=describeuser.html&login=carlosg%40gnome.org" title="Carlos Garnacho <carlosg@gnome.org>"> <span class="fn">Carlos Garnacho</span></a>
</span></b>
        <pre>(In reply to Milan Crha from <a href="show_bug.cgi?id=789268#c12">comment #12</a>)
<span class="quote">> (In reply to Jonas Ã…dahl from <a href="show_bug.cgi?id=789268#c7">comment #7</a>)
> > The date-picker popup, what is it made out of? It sounds like it is not
> > turned into a popup in the GDK backend, but it probably should have.

> It's just one example (see <a href="show_bug.cgi?id=789268#c3">comment #3</a>, it's the e-dateedit.c in the list).
> It is created as a GTK_WINDOW_POPUP GtkWindow:
> <a href="https://git.gnome.org/browse/evolution/tree/src/e-util/e-dateedit.c?h=gnome">https://git.gnome.org/browse/evolution/tree/src/e-util/e-dateedit.c?h=gnome</a>-
> 3-24#n652
> Then it is shown, and the grabs are done, here:
> <a href="https://git.gnome.org/browse/evolution/tree/src/e-util/e-dateedit.c?h=gnome">https://git.gnome.org/browse/evolution/tree/src/e-util/e-dateedit.c?h=gnome</a>-
> 3-24#n1444</span >

Porting to gdk_seat_grab() is still highly recommended :), it makes both
showing the popup window and grabbing the input devices "atomic" from the
caller perspective. The GDK wayland backend can barely make sense of the three
calls done separately.

Seeing that you actually grab both pointer and keyboard (I oversaw that the
GdkDevice::grab vfunc on the keyboard would still trigger shortcut inhibition
despite the pointer grab), a gdk_seat_grab() call on GDK_SEAT_CAPABILITY_ALL
would have resulted on correct behavior.

(In reply to Olivier Fourdan from <a href="show_bug.cgi?id=789268#c14">comment #14</a>)
<span class="quote">> I am tempted to say let's use this as a workaround (that will fix evo and
> possibly others w/out breaking other apps that need shortcuts inhibition)
> while the decision to keep or remove the dialog in mutter/gnome-shell is
> left pending?</span >

I'll be more romantic and call it "heuristic" :p, IMHO the dialog is good to
have, but it's unlikely that a popup window actually demands the functionality.

Seeing that it may also happen with the traditional 2 gdk_device_grab() calls,
I think something must be done in GTK+, indeed. Will move the bug there.</pre>
        </div>
      </p>
      <hr>
      <span>You are receiving this mail because:</span>
      
      <ul>
          <li>You are on the CC list for the bug.</li>
      </ul>
    </body>
</html>