<html>
<head>
<base href="https://bugzilla.gnome.org/" />
</head>
<body><span class="vcard"><a href="page.cgi?id=describeuser.html&login=jadahl%40gmail.com" title="Jonas Ådahl <jadahl@gmail.com>"> <span class="fn">Jonas Ådahl</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Restoring maximized window state in Wayland results in tiny window"
href="https://bugzilla.gnome.org/show_bug.cgi?id=783901">bug 783901</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #354148 status</td>
<td>none
</td>
<td>reviewed
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Restoring maximized window state in Wayland results in tiny window"
href="https://bugzilla.gnome.org/show_bug.cgi?id=783901#c31">Comment # 31</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Restoring maximized window state in Wayland results in tiny window"
href="https://bugzilla.gnome.org/show_bug.cgi?id=783901">bug 783901</a>
from <span class="vcard"><a href="page.cgi?id=describeuser.html&login=jadahl%40gmail.com" title="Jonas Ådahl <jadahl@gmail.com>"> <span class="fn">Jonas Ådahl</span></a>
</span></b>
<pre>Review of <span class=""><a href="attachment.cgi?id=354148&action=diff" name="attach_354148" title="[PATCH 3/3] wayland: update location prior to maximize">attachment 354148</a> <a href="attachment.cgi?id=354148&action=edit" title="[PATCH 3/3] wayland: update location prior to maximize">[details]</a></span> <a href='review?bug=783901&attachment=354148'>[review]</a>:
::: src/wayland/meta-wayland-xdg-shell.c
@@ +355,3 @@
+ /* Make sure the position is up-to-date prior to call maximize */
+ window->rect.x = window->unconstrained_rect.x;
+ window->rect.y = window->unconstrained_rect.y;
This looks like its working around something in force_placement().
Shouldn't we fix this in meta_window_wayland_move_resize_internal()? It looks
like we should be able to set "can_move_now" to TRUE if we are "!placed" (which
will be set to TRUE after the move resize call), or possibly adding another
MOVE_RESIZE flag "force" that forces the placement?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>