<html>
<head>
<base href="https://bugzilla.gnome.org/" />
</head>
<body><span class="vcard"><a href="page.cgi?id=describeuser.html&login=jadahl%40gmail.com" title="Jonas Ådahl <jadahl@gmail.com>"> <span class="fn">Jonas Ådahl</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [Wayland] Focused window under application first window"
href="https://bugzilla.gnome.org/show_bug.cgi?id=780820">bug 780820</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #366553 status</td>
<td>none
</td>
<td>reviewed
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [Wayland] Focused window under application first window"
href="https://bugzilla.gnome.org/show_bug.cgi?id=780820#c24">Comment # 24</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [Wayland] Focused window under application first window"
href="https://bugzilla.gnome.org/show_bug.cgi?id=780820">bug 780820</a>
from <span class="vcard"><a href="page.cgi?id=describeuser.html&login=jadahl%40gmail.com" title="Jonas Ådahl <jadahl@gmail.com>"> <span class="fn">Jonas Ådahl</span></a>
</span></b>
<pre>Review of <span class=""><a href="attachment.cgi?id=366553&action=diff" name="attach_366553" title="[PATCH v4] window: Defer stack placement without a buffer">attachment 366553</a> <a href="attachment.cgi?id=366553&action=edit" title="[PATCH v4] window: Defer stack placement without a buffer">[details]</a></span> <a href='review?bug=780820&attachment=366553'>[review]</a>:
::: src/core/window-private.h
@@ +701,3 @@
void meta_window_frame_size_changed (MetaWindow *window);
+gboolean meta_window_in_stack (MetaWindow *window);
better name (follows convention):
meta_window_is_in_stack(). Alternatively meta_window_is_stacked().
::: src/core/window.c
@@ +1701,3 @@
+ /* If showing a window that wasn't added to the stack yet, make sure we
+ * add it to the stack now.
+ * See #780820
This comment just spells out what the statement below does. Suggestion:
/* Some windows are not stackable until being showed, so add those now. */
(the bug link (number will be ambiguous with the move to gitlab (even though we
hopefully won't have 780k bugs just on mutter!) will be easily discoverable
using git annotate)
@@ +6908,3 @@
+meta_window_in_stack (MetaWindow *window)
+{
+ return (window->stack_position >= 0);
why the ( and )?
::: src/wayland/meta-window-wayland.c
@@ +547,3 @@
+meta_window_wayland_is_stackable (MetaWindow *window)
+{
+ /* Surface without a buffer attached yet should not be added to the stack */
This comment spells out what is done below so no need for it.
@@ +548,3 @@
+{
+ /* Surface without a buffer attached yet should not be added to the stack */
+ return (meta_wayland_surface_get_buffer (window->surface) != NULL);
Why the ( and )?
::: src/x11/window-x11.c
@@ +1554,3 @@
+{
+ /* For X11, do not add OR windows to the stack */
+ return (!window->override_redirect);
Same here about the comment being the line of code but in english, and about
the ( and ).</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>