<html>
<head>
<base href="https://bugzilla.gnome.org/" />
</head>
<body><span class="vcard"><a href="page.cgi?id=describeuser.html&login=jadahl%40gmail.com" title="Jonas Ådahl <jadahl@gmail.com>"> <span class="fn">Jonas Ådahl</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Entry completion drop-down is misplaced on external monitor when on Wayland"
href="https://bugzilla.gnome.org/show_bug.cgi?id=774065">bug 774065</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #366086 status</td>
<td>none
</td>
<td>reviewed
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Entry completion drop-down is misplaced on external monitor when on Wayland"
href="https://bugzilla.gnome.org/show_bug.cgi?id=774065#c10">Comment # 10</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Entry completion drop-down is misplaced on external monitor when on Wayland"
href="https://bugzilla.gnome.org/show_bug.cgi?id=774065">bug 774065</a>
from <span class="vcard"><a href="page.cgi?id=describeuser.html&login=jadahl%40gmail.com" title="Jonas Ådahl <jadahl@gmail.com>"> <span class="fn">Jonas Ådahl</span></a>
</span></b>
<pre>Review of <span class=""><a href="attachment.cgi?id=366086&action=diff" name="attach_366086" title="Patch using gdk_window_move_to_rect instead of gtk_window_move">attachment 366086</a> <a href="attachment.cgi?id=366086&action=edit" title="Patch using gdk_window_move_to_rect instead of gtk_window_move">[details]</a></span> <a href='review?bug=774065&attachment=366086'>[review]</a>:
Thanks a lot for this! Here is some review:
Have this been tested on both input grabbing and not input grabbing entry
completion? Do we have test cases for both kinds?
Another question is how this deals with entry completion windows being moved,
as move_to_rect() can't deal with moving visible windows right now. Do we have
test cases for that? Do we even support that?
Lastly, for the future, please attach patches generated from "git format-patch"
with commit message and author information.
::: gtk/gtkentrycompletion.c
@@ +609,3 @@
priv->popup_window = gtk_window_new (GTK_WINDOW_POPUP);
+ /* Using subsurface prevents gdk_window_move_to_rect from working */
+ /* gtk_window_set_use_subsurface (GTK_WINDOW (priv->popup_window), TRUE); */
We should just remove this, not comment it out.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>