<html> <head> <base href="https://bugzilla.gnome.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - Entry completion drop-down is misplaced on external monitor when on Wayland" href="https://bugzilla.gnome.org/show_bug.cgi?id=774065#c11">Comment # 11</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - Entry completion drop-down is misplaced on external monitor when on Wayland" href="https://bugzilla.gnome.org/show_bug.cgi?id=774065">bug 774065</a> from <a href="page.cgi?id=describeuser.html&login=xovni%40wanadoo.fr" title="Guillaume Ayoub <xovni@wanadoo.fr>"> Guillaume Ayoub</a> <pre>(In reply to Jonas Ådahl from <a href="show_bug.cgi?id=774065#c10">comment #10</a>) > Review of <a href="attachment.cgi?id=366086&action=diff" name="attach_366086" title="Patch using gdk_window_move_to_rect instead of gtk_window_move">attachment 366086</a> <a href="attachment.cgi?id=366086&action=edit" title="Patch using gdk_window_move_to_rect instead of gtk_window_move">[details]</a> <a href='review?bug=774065&attachment=366086'>[review]</a> [review]: > > Thanks a lot for this! I've done my best, but it looks like an ugly patch, not a real solution. I've tried with Xorg and it's broken :/. > Here is some review: > > Have this been tested on both input grabbing and not input grabbing entry > completion? Do we have test cases for both kinds? No, I don't even know what you're talking about… > Another question is how this deals with entry completion windows being > moved, as move_to_rect() can't deal with moving visible windows right now. > Do we have test cases for that? Do we even support that? It's possible to move the input window when the dropdown window is open, for example by maximizing/minimizing epiphany using keyboard shortcuts. With the patch, the dropdown window doesn't move with the input window. I don't know how it was before the patch. > Lastly, for the future, please attach patches generated from "git > format-patch" with commit message and author information. I'll try to remember that! > ::: gtk/gtkentrycompletion.c > @@ +609,3 @@ > priv->popup_window = gtk_window_new (GTK_WINDOW_POPUP); > + /* Using subsurface prevents gdk_window_move_to_rect from working */ > + /* gtk_window_set_use_subsurface (GTK_WINDOW (priv->popup_window), TRUE); > */ > > We should just remove this, not comment it out. Of course.</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are on the CC list for the bug.</li> </ul> </body> </html>