<html>
<head>
<base href="https://bugzilla.gnome.org/" />
</head>
<body><span class="vcard"><a href="page.cgi?id=describeuser.html&login=bugzilla%40hadess.net" title="Bastien Nocera <bugzilla@hadess.net>"> <span class="fn">Bastien Nocera</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - wayland: fix fontconfig monitoring"
href="https://bugzilla.gnome.org/show_bug.cgi?id=786693">bug 786693</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #368197 status</td>
<td>accepted-commit_now
</td>
<td>needs-work
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - wayland: fix fontconfig monitoring"
href="https://bugzilla.gnome.org/show_bug.cgi?id=786693#c5">Comment # 5</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - wayland: fix fontconfig monitoring"
href="https://bugzilla.gnome.org/show_bug.cgi?id=786693">bug 786693</a>
from <span class="vcard"><a href="page.cgi?id=describeuser.html&login=bugzilla%40hadess.net" title="Bastien Nocera <bugzilla@hadess.net>"> <span class="fn">Bastien Nocera</span></a>
</span></b>
<pre>Review of <span class=""><a href="attachment.cgi?id=368197" name="attach_368197" title="'gtk-fontconfig-timestamp' for Wayland (timestamp as int64)">attachment 368197</a> <a href="attachment.cgi?id=368197&action=edit" title="'gtk-fontconfig-timestamp' for Wayland (timestamp as int64)">[details]</a></span> <a href='review?bug=786693&attachment=368197'>[review]</a>:
I don't think this is a good enough interface for GTK+ to use, but best discuss
it in a location where it will be implemented (in gnome-settings-daemon)
::: gdk/wayland/gdkscreen-wayland.c
@@ +919,3 @@
+ if (proxy == NULL)
+ {
+ if (error != NULL)
This will warn for every GTK+ app running under a non-GNOME Wayland server.
@@ +946,3 @@
+ screen_wayland->fc_settings.timestamp = (guint)timestamp;
+ else if (timestamp > G_MAXUINT)
+ g_warning ("Could not handle fontconfig init: timestamp too long");
too long?
@@ +975,3 @@
+ G_DBUS_PROXY_FLAGS_NONE,
+ NULL,
+ GSD_DBUS_FONTCONFIG_NAME,
This is highly GNOME specific.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>