<html>
<head>
<base href="https://bugzilla.gnome.org/" />
</head>
<body><span class="vcard"><a href="page.cgi?id=describeuser.html&login=tchaik%40gmx.com" title="Martin Blanchard <tchaik@gmx.com>"> <span class="fn">Martin Blanchard</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - wayland: fix fontconfig monitoring"
href="https://bugzilla.gnome.org/show_bug.cgi?id=786693">bug 786693</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #368982 status</td>
<td>needs-work
</td>
<td>none
</td>
</tr>
<tr>
<td style="text-align:right;">Attachment #368982 is obsolete</td>
<td>
</td>
<td>1
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - wayland: fix fontconfig monitoring"
href="https://bugzilla.gnome.org/show_bug.cgi?id=786693#c9">Comment # 9</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - wayland: fix fontconfig monitoring"
href="https://bugzilla.gnome.org/show_bug.cgi?id=786693">bug 786693</a>
from <span class="vcard"><a href="page.cgi?id=describeuser.html&login=tchaik%40gmx.com" title="Martin Blanchard <tchaik@gmx.com>"> <span class="fn">Martin Blanchard</span></a>
</span></b>
<pre>Created <span class=""><a href="attachment.cgi?id=369118" name="attach_369118" title="'gtk-fontconfig-timestamp' and 'gtk-modules' for Wayland">attachment 369118</a> <a href="attachment.cgi?id=369118&action=edit" title="'gtk-fontconfig-timestamp' and 'gtk-modules' for Wayland">[details]</a></span> <a href='review?bug=786693&attachment=369118'>[review]</a>
'gtk-fontconfig-timestamp' and 'gtk-modules' for Wayland
Fourth version: Handle both 'gtk-fontconfig-timestamp' and 'gtk-modules'.
(In reply to Bastien Nocera from <a href="show_bug.cgi?id=786693#c8">comment #8</a>)
<span class="quote">> It also looks easy enough to extend and add support for the 2 other
> GtkSettings if you're interested.</span >
Hummm, isn't 'gtk-enable-animations' already implemented as a gsetting?
<span class="quote">> ::: gdk/wayland/gdkscreen-wayland.c
> @@ +70,3 @@
> Why use a struct here, and not directly a timestamp? The struct will be
> initialised to 0 when it's instantiated.</span >
I've kept the struct so that dbus settings are grouped, that make it clear that
they'll be handle together.
<span class="quote">> @@ +116,3 @@
> You can replace both lines with g_clear_object();</span >
Done.
<span class="quote">> @@ +713,3 @@
> Why the guard here? Wouldn't you want to return the "0" instead of an error
> here?</span >
You're right, the distinction between a somehow fake initial value and 0 is of
little interest here.
<span class="quote">> @@ +872,3 @@
> You can replace this loop with g_variant_lookup_value()
> Don't forget to exit early if the timestamp wasn't found.</span >
Done.
<span class="quote">> @@ +914,3 @@
> Either you should not use an error at all (you don't do anything with it),
> or you should have a few cases and print errors if the error is something
> other than the call being cancelled, or org.gtk.Settings not existing.</span >
Agreed, my bad.
<span class="quote">> @@ +969,3 @@
> You'll also want to add a cancellable here, which you would cancel and
> destroy in the finalize function.</span >
Done.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>