<html>
<head>
<base href="https://bugzilla.gnome.org/" />
</head>
<body><span class="vcard"><a href="page.cgi?id=describeuser.html&login=bugzilla%40hadess.net" title="Bastien Nocera <bugzilla@hadess.net>"> <span class="fn">Bastien Nocera</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - wayland: fix fontconfig monitoring"
href="https://bugzilla.gnome.org/show_bug.cgi?id=786693">bug 786693</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #369118 status</td>
<td>none
</td>
<td>needs-work
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - wayland: fix fontconfig monitoring"
href="https://bugzilla.gnome.org/show_bug.cgi?id=786693#c10">Comment # 10</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - wayland: fix fontconfig monitoring"
href="https://bugzilla.gnome.org/show_bug.cgi?id=786693">bug 786693</a>
from <span class="vcard"><a href="page.cgi?id=describeuser.html&login=bugzilla%40hadess.net" title="Bastien Nocera <bugzilla@hadess.net>"> <span class="fn">Bastien Nocera</span></a>
</span></b>
<pre>Review of <span class=""><a href="attachment.cgi?id=369118" name="attach_369118" title="'gtk-fontconfig-timestamp' and 'gtk-modules' for Wayland">attachment 369118</a> <a href="attachment.cgi?id=369118&action=edit" title="'gtk-fontconfig-timestamp' and 'gtk-modules' for Wayland">[details]</a></span> <a href='review?bug=786693&attachment=369118'>[review]</a>:
Looks good otherwise.
::: gdk/wayland/gdkscreen-wayland.c
@@ +929,3 @@
+ proxy = g_dbus_proxy_new_for_bus_finish (result, NULL);
+
+ g_clear_object (&screen_wayland->dbus_cancellable);
No, don't do this, keep it around.
Instead, you'll want to cancel it it in dispose().
@@ +955,3 @@
+ }
+
+ g_variant_unref (value);
g_variant_unref() doesn't like being passed NULL.
@@ +963,3 @@
+ {
+ modules = g_variant_get_string (value, &length);
+ screen_wayland->dbus_settings.modules = g_strndup (modules, length);
You're leaking the old value of dbus_settings.modules.
Seeing as the string will be nul-terminated, free the old string, and use
g_variant_dup_string() to assign the new value.
@@ +966,3 @@
+ }
+
+ g_variant_unref (value);
Ditto.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>