<html>
<head>
<base href="https://bugzilla.gnome.org/" />
</head>
<body><span class="vcard"><a href="page.cgi?id=describeuser.html&login=tchaik%40gmx.com" title="Martin Blanchard <tchaik@gmx.com>"> <span class="fn">Martin Blanchard</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - wayland: fix fontconfig monitoring"
href="https://bugzilla.gnome.org/show_bug.cgi?id=786693">bug 786693</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #369118 status</td>
<td>needs-work
</td>
<td>none
</td>
</tr>
<tr>
<td style="text-align:right;">Attachment #369118 is obsolete</td>
<td>
</td>
<td>1
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - wayland: fix fontconfig monitoring"
href="https://bugzilla.gnome.org/show_bug.cgi?id=786693#c12">Comment # 12</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - wayland: fix fontconfig monitoring"
href="https://bugzilla.gnome.org/show_bug.cgi?id=786693">bug 786693</a>
from <span class="vcard"><a href="page.cgi?id=describeuser.html&login=tchaik%40gmx.com" title="Martin Blanchard <tchaik@gmx.com>"> <span class="fn">Martin Blanchard</span></a>
</span></b>
<pre>Created <span class=""><a href="attachment.cgi?id=369162" name="attach_369162" title="'gtk-fontconfig-timestamp' and 'gtk-modules' for Wayland">attachment 369162</a> <a href="attachment.cgi?id=369162&action=edit" title="'gtk-fontconfig-timestamp' and 'gtk-modules' for Wayland">[details]</a></span> <a href='review?bug=786693&attachment=369162'>[review]</a>
'gtk-fontconfig-timestamp' and 'gtk-modules' for Wayland
Fifth version: Keep dbus connection's cancellable alive all along
GdkWaylandScreen's lifetime.
(In reply to Bastien Nocera from <a href="show_bug.cgi?id=786693#c10">comment #10</a>)
<span class="quote">> @@ +929,3 @@
> + g_clear_object (&screen_wayland->dbus_cancellable);
>
> No, don't do this, keep it around.
> Instead, you'll want to cancel it it in dispose().</span >
Ok.
<span class="quote">> @@ +955,3 @@
> + }
> +
> + g_variant_unref (value);
>
> g_variant_unref() doesn't like being passed NULL.</span >
Ouch...
<span class="quote">> @@ +963,3 @@
> + {
> + modules = g_variant_get_string (value, &length);
> + screen_wayland->dbus_settings.modules = g_strndup (modules, length);
>
> You're leaking the old value of dbus_settings.modules.
>
> Seeing as the string will be nul-terminated, free the old string, and use
> g_variant_dup_string() to assign the new value.</span >
Well, I'm expecting this to be called only once, at object's initialisation
time. Are there any case where this would be called again for the same
GdkWaylandScreen instance? Anyway, string gets freed now.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>