<html>
<head>
<base href="https://bugzilla.gnome.org/" />
</head>
<body><span class="vcard"><a href="page.cgi?id=describeuser.html&login=bugzilla%40hadess.net" title="Bastien Nocera <bugzilla@hadess.net>"> <span class="fn">Bastien Nocera</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - wayland: fix fontconfig monitoring"
href="https://bugzilla.gnome.org/show_bug.cgi?id=786693">bug 786693</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #369162 status</td>
<td>none
</td>
<td>reviewed
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - wayland: fix fontconfig monitoring"
href="https://bugzilla.gnome.org/show_bug.cgi?id=786693#c14">Comment # 14</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - wayland: fix fontconfig monitoring"
href="https://bugzilla.gnome.org/show_bug.cgi?id=786693">bug 786693</a>
from <span class="vcard"><a href="page.cgi?id=describeuser.html&login=bugzilla%40hadess.net" title="Bastien Nocera <bugzilla@hadess.net>"> <span class="fn">Bastien Nocera</span></a>
</span></b>
<pre>Review of <span class=""><a href="attachment.cgi?id=369162" name="attach_369162" title="'gtk-fontconfig-timestamp' and 'gtk-modules' for Wayland">attachment 369162</a> <a href="attachment.cgi?id=369162&action=edit" title="'gtk-fontconfig-timestamp' and 'gtk-modules' for Wayland">[details]</a></span> <a href='review?bug=786693&attachment=369162'>[review]</a>:
Just some nits. You don't need to upload a new version, I'd wait until a GTK+
developer can review and merge this now.
::: gdk/wayland/gdkscreen-wayland.c
@@ +99,3 @@
GdkWaylandScreen *screen_wayland = GDK_WAYLAND_SCREEN (object);
+ if (screen_wayland->dbus_proxy && screen_wayland->dbus_setting_change_id)
Linefeed after &&
Add > 0 to change_id conditional.
@@ +947,3 @@
+ g_warning ("Could not handle fontconfig init: timestamp out of
bound");
+
+ g_variant_unref (value);
You need to call those outside the if block, otherwise you'll be leaking the
value if it doesn't match the expected type.
@@ +959,3 @@
+ screen_wayland->dbus_settings.modules = g_variant_dup_string (value,
NULL);
+
+ g_variant_unref (value);
Same thing here.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>