<html> <head> <base href="https://bugs.freedesktop.org/"> </head> <body> <div> <a class="bz_bug_link bz_status_NEEDINFO " title="NEEDINFO - SW_TABLET_MODE disables monitor bezel button in tablet mode" href="https://bugs.freedesktop.org/show_bug.cgi?id=103749#c28">Comment # 28</a> on <a class="bz_bug_link bz_status_NEEDINFO " title="NEEDINFO - SW_TABLET_MODE disables monitor bezel button in tablet mode" href="https://bugs.freedesktop.org/show_bug.cgi?id=103749">bug 103749</a> from <a class="email" href="mailto:davide@depau.eu" title="Davide Depau <davide@depau.eu>"> Davide Depau</a> <pre>(In reply to Peter Hutterer from <a href="show_bug.cgi?id=103749#c27">comment #27</a>) > Comment on <a href="attachment.cgi?id=138226" name="attach_138226" title="0001-evdev-don-t-suspend-keyboard-on-the-X1-Yoga-1st-DEPAU.patch">attachment 138226</a> <a href="attachment.cgi?id=138226&action=edit" title="0001-evdev-don-t-suspend-keyboard-on-the-X1-Yoga-1st-DEPAU.patch">[details]</a> <a href='page.cgi?id=splinter.html&bug=103749&attachment=138226'>[review]</a> [review] > 0001-evdev-don-t-suspend-keyboard-on-the-X1-Yoga-1st-DEPAU.patch > > Review of <a href="attachment.cgi?id=138226" name="attach_138226" title="0001-evdev-don-t-suspend-keyboard-on-the-X1-Yoga-1st-DEPAU.patch">attachment 138226</a> <a href="attachment.cgi?id=138226&action=edit" title="0001-evdev-don-t-suspend-keyboard-on-the-X1-Yoga-1st-DEPAU.patch">[details]</a> <a href='page.cgi?id=splinter.html&bug=103749&attachment=138226'>[review]</a> [review]: > ----------------------------------------------------------------- > > This should work, but it's inefficient. You're still pairing the tablet mode > and the keyboard device, installing an event handler, etc. But then you just > return early when the event comes in. The original patch from <a href="show_bug.cgi?id=103749#c15">comment 15</a> > just skips the pairing, which means it should have the same effect. So it'd > be useful to debug why the other patch didn't take effect in > fallback_keyboard_pair_tablet_mode(). I'll try to check again tomorrow or in the next few days and come up with something more efficient. > ::: src/evdev-fallback.c > @@ +1151,4 @@ > > swev = libinput_event_get_switch_event(event); > > if (libinput_event_switch_get_switch(swev) != > > LIBINPUT_SWITCH_TABLET_MODE) > > + return; > > detritus, please remove > > @@ +1155,3 @@ > > > > + if (device->model_flags & EVDEV_MODEL_TABLET_MODE_NO_SUSPEND) > > + return; > > please stick to the indentation rules the rest of libinput uses IDE's fault ;)</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the assignee for the bug.</li> </ul> </body> </html>