<html> <head> <base href="https://bugs.freedesktop.org/"> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - Lenovo P50 - Slow fine touchpad movement makes it jump (bug 2)" href="https://bugs.freedesktop.org/show_bug.cgi?id=105963#c20">Comment # 20</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - Lenovo P50 - Slow fine touchpad movement makes it jump (bug 2)" href="https://bugs.freedesktop.org/show_bug.cgi?id=105963">bug 105963</a> from <a class="email" href="mailto:peter.hutterer@who-t.net" title="Peter Hutterer <peter.hutterer@who-t.net>"> Peter Hutterer</a> <pre>Comment on <a href="attachment.cgi?id=138755" name="attach_138755" title="Patch to reapply the p50 rule & fix syntax error in existing rules">attachment 138755</a> <a href="attachment.cgi?id=138755&action=edit" title="Patch to reapply the p50 rule & fix syntax error in existing rules">[details]</a> <a href='page.cgi?id=splinter.html&bug=105963&attachment=138755'>[review]</a> Patch to reapply the p50 rule & fix syntax error in existing rules Review of <a href="attachment.cgi?id=138755" name="attach_138755" title="Patch to reapply the p50 rule & fix syntax error in existing rules">attachment 138755</a> <a href="attachment.cgi?id=138755&action=edit" title="Patch to reapply the p50 rule & fix syntax error in existing rules">[details]</a> <a href='page.cgi?id=splinter.html&bug=105963&attachment=138755'>[review]</a>: ----------------------------------------------------------------- As a general rule, please always separate logical steps within patches. Adding a new device should not be combined with fixing another device - makes it hard to separate the patches out for e.g. stable branches or regression testing. So this patch would have to be two patches, one for the P50, one for the alleged syntax error. Alas, that 'syntax error' is intentional, these Lenovo series have an optional suffix as well (T450, T450s, T450p, ...). They all have the same hardware, so this rule catches all. It should arguably be a ? instead as there is only one letter but the current rule works. The trailing : doesn't matter because all modalias have a trailing ':'. So it doesn't quite match as you'd expect but it does match :) As for the P50 patch - this is the same as in <a class="bz_bug_link bz_status_REOPENED " title="REOPENED - Lenovo P50 - Slow fine touchpad movement makes it jump" href="show_bug.cgi?id=105022">bug 105022</a> now, right? That one apparently made scrolling unworkable so I had to revert it upstream. Does this patch have any effect on scrolling for you?</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the assignee for the bug.</li> </ul> </body> </html>