[PATCH] shell: fix set_transient

Tiago Vignatti tiago.vignatti at linux.intel.com
Thu Dec 8 07:04:47 PST 2011


On 12/08/2011 04:42 PM, Pekka Paalanen wrote:
> In the wl_shell_surface migration, I forgot to correct one cast in
> shell_surface_set_transient(). 'parent_resource' is not a (struct
> wlsc_surface *) but (struct shell_surface *).
>
> This bug corrupts a wlsc_surface::output field, which later (in my
> experiments) leads to a segmentation fault in surface_frame().
>
> Fix the casts.
>
> Signed-off-by: Pekka Paalanen<ppaalanen at gmail.com>

Reviewed-by: Tiago Vignatti <tiago.vignatti at intel.com>

but I thought you'd implement the explicit cast scheme.. meh.

      Tiago


More information about the wayland-devel mailing list