[PATCH 2/4] config: fix boolean parsing

Alexandre Bique bique.alexandre at gmail.com
Tue Nov 15 06:27:34 PST 2011


On Tue, Nov 15, 2011 at 10:45 AM, Pekka Paalanen <ppaalanen at gmail.com> wrote:
> The rest of the line contains the newline, so cannot match simply 'true'
> or 'false'.

Hi Pekka,

I am not familiar with wayland's code and I didn't even read it.
But it feels weird to include the trailing \n of the value when
parsing the config file.

What appends if value is "true\r\n" ?

I believe that the code is correct, but would it be better to review
the tokening ?

Thanks.

-- 
Alexandre Bique


More information about the wayland-devel mailing list