[PATCH 0/9] evdev: events processing after EV_SYN and hotplug support

Kristian Høgsberg krh at bitplanet.net
Mon Oct 24 08:27:55 PDT 2011

On Mon, Oct 24, 2011 at 10:42 AM, Tiago Vignatti
<tiago.vignatti at intel.com> wrote:
> Hi,
> There it goes a bit of refactoring on the evdev code to become more, well,
> usable. Nothing exceptional really and the most apparent change is the hotplug
> feature added... ahh, one would say I'm a thief maybe because a lot of code
> was based on the X input evdev driver :)

It all looks good except for patch 8/9 and the few minor comments here
and there.  As for 8/9, I don't think we need a 32 deep event queue to
deal with the SYN events properly.  We're never going to get more than
one key or button press or release per SYN event, and only one event
per axis.  So we should be able to just set a flag to track which one
it was and store the key or button code or the axis value, and then
just deliver it at SYN time.


> The same work is here:
>    http://cgit.freedesktop.org/~vignatti/wayland-demos/log/?h=master-evdev
>     Tiago
> Tiago Vignatti (9):
>  evdev: use struct calibration for those kind of fields
>  evdev: delete unused fields from evdev_input_device
>  evdev: record valuators coordinates in evdev_input_device
>  evdev: record absolute events were queued inside evdev_input_device
>  evdev: record time inside evdev_input_device
>  evdev: organize main event processing loop
>  evdev: queue events and process them only at EV_SYN time
>  evdev: add hotplug support
>  evdev: simplify error path for device create
>  compositor/evdev.c |  494 ++++++++++++++++++++++++++++++++++++++++------------
>  1 files changed, 386 insertions(+), 108 deletions(-)
> --

More information about the wayland-devel mailing list