[PATCH 0/2] Fix release of wrong buffer on frame complete

Kristian Høgsberg krh at bitplanet.net
Mon Oct 24 13:03:44 PDT 2011


2011/10/21 Kristian Høgsberg <krh at bitplanet.net>:
> On Tue, Oct 18, 2011 at 10:02 AM, Tiago Vignatti
> <tiago.vignatti at intel.com> wrote:
>> From: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira at intel.com>
>>
>> If scanning out a client buffer, the compositor will send a buffer
>> release event for the front buffer as soon as the flip completes. This
>> series change the behavior to send the release event for the previous
>> front buffer.
>>
>> The second patch is a kind of ugly and duplicates some code.
>> Suggestions of how to do it better are very welcome.
>
> The patches look good, and I'll push them in a bit.  For some reason,
> the drm compositor doesn't work on my SNB laptop right now, so I'll
> have to figure that out first.

Ok, what happened was that intel kms started failing on depth=32.  The
compositor now asks for depth 24 and we're back to working.  I've
applied your fixes here and a little follow up patch which makes the
logic a little more clear.

thanks,
Kristian

>> Thanks,
>> Ander
>>
>> Ander Conselvan de Oliveira (2):
>>  compositor: move setup of scanout surface out of wlsc_output_repaint
>>  compositor: don't release the front buffer after page flip
>>
>>  compositor/compositor.c |   58 ++++++++++++++++++++++++++++++++++++++---------
>>  compositor/compositor.h |    2 +
>>  2 files changed, 49 insertions(+), 11 deletions(-)
>>
>> --
>> 1.7.4.1
>>
>> _______________________________________________
>> wayland-devel mailing list
>> wayland-devel at lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/wayland-devel
>>
>


More information about the wayland-devel mailing list