[PATCH 1/2] wl_shell: check the parameter sent by the clients

Zhao, Juan J juan.j.zhao at intel.com
Mon Oct 31 06:05:47 PDT 2011


Thanks. Sorry for the instant sending patch. :)
Yes, I will change it. Looks like bnf's patch will resolve this. I will check it tomorrow morning, if that can work well, we do not need this patch.

> -----Original Message-----
> From: Daniel Stone [mailto:daniel at fooishbar.org]
> Sent: Monday, October 31, 2011 7:14 PM
> To: Zhao, Juan J
> Cc: wayland-devel at lists.freedesktop.org
> Subject: Re: [PATCH 1/2] wl_shell: check the parameter sent by the clients
> 
> Hi,
> 
> On 31 October 2011 07:17,  <juan.j.zhao at intel.com> wrote:
> > +        if((struct wl_interface *)
> > +            (((struct wl_object *)surface_resource)->interface)->name
> > +              !="wl_surface")
> 
> This is, er, not how you perform string comparison in C.
> 
> Cheers,
> Daniel


More information about the wayland-devel mailing list