[PATCH 5/6 xserver] xwayland: make more explicit root window creation path

Daniel Stone daniel at fooishbar.org
Tue Apr 3 07:18:49 PDT 2012


Hi,

On 3 April 2012 14:58, Tiago Vignatti <tiago.vignatti at intel.com> wrote:
> Just moving code around. No functional changes.

Sorry, I'm not sure I really like this one, unless you're planning to
add an else branch; even then, that might well be fodder for helper
functions.  The early-return style is good not only at reducing our
indentation levels -- which is pretty essential with eight-space
indents -- but also at making it immediately obvious what's going to
get returned for the uncommon case.

Cheers,
Daniel


More information about the wayland-devel mailing list