[RFC PATCH 06/12] tablet-shell: Applications can run on tablet

Juan Zhao juan.j.zhao at linux.intel.com
Mon Aug 6 18:35:44 PDT 2012


Thanks, Tiago. :)
It's helpful.

On Mon, 2012-08-06 at 11:35 +0300, Tiago Vignatti wrote:
> Hi Juan,
> 
> There's an intentional separation of the wl_shell_surface_interface
> on 
> its own (desktop) shell file. Its purpose is for building full
> desktop 
> interfaces, in principle, and in fact things like _move, _resize, 
> _set_title and etc don't make sense on tablet style of interface. 

Yes, and to make the toy toolkit client, and efl clients also workable
in tablet-shell, we need to provide an interface related to them.

> So 
> what you're suggesting here doesn't make sense either when a client 
> would be replying to a fullscreen event, because what we want is to
> all 
> tablet clients be fullscreen. We need is just a way to configure the 
> clients always like that and I believe this code is already in place
> on 
> tablet-shell.c.

Most of the clients have a state when it was fullscreen, and they may
have different responses in this condition. Thinking of this, so we
added an send_fullscreen event to the client.
> 
> Another tip, try to work a bit more on the commit messages and its 
> subject line:
> 
> http://vignatti.wordpress.com/2010/07/12/attracting-reviewers-in-your-patch-series/

Thanks, we are refining it, it is still on development. And we like to
hear your voices to make it better. And of course, we will refine the
patchset. ^_^ 

Juan


> Tiago 



More information about the wayland-devel mailing list