[PATCH 3/3] wayland-cursor: Adapt to new shm pool helper functions

Andre Heider a.heider at gmail.com
Tue Aug 7 06:21:00 PDT 2012


On Tue, Aug 7, 2012 at 2:15 PM, Ander Conselvan de Oliveira
<conselvan2 at gmail.com> wrote:
> I like to have the allocate function try to resize the pool if needed. All
> users except wayland-cursor allocate a pool large enough, so they should
> never reach and on the other hand its convenient not to have to write the
> resize logic every time one needs it.
>
> I would go for having the resize by default, and if there is a use case
> where we really don't want to resize, we could have something like:
>
> enum wl_shm_mapping_resize_behavior {
>         /* never try to resize */
>         WL_SHM_MAPPING_RESIZE_NEVER,
>
>         /* try to resize to current size + new allocation size */
>         WL_SHM_MAPPING_RESIZE_ADD_SIZE,
>
>         /* double the allocation size until it is large enough */
>         WL_SHM_MAPPING_RESIZE_DOUBLE,
>
>         ...
> };

I like that, that's flexible enough for now and the enum can be
extended when required without API/ABI breakage.

Thanks,
Andre


More information about the wayland-devel mailing list