[RFC PATCH 06/12] tablet-shell: Applications can run on tablet

[Juan Zhao]

On Tue, 2012-08-07 at 09:36 +0300, Pekka Paalanen wrote:
> Hi,
> 
> I didn't quite understand Tiago's reply, but maybe the following
> helps.

Thanks, pq, sure, it helps. :)
> 
> Looking at the tablet-shell.xml protocol, I wonder if it is missing an
> interface. The interface tablet_shell seems to be private for the
> ux-daemon (tablet-shell client), but there is no interface for normal
> clients. 

I think tablet-shell is used for embeded systems, like ivi/handset/tv.
Not only ux-daemon. 

> I doubt that any normal client should be able to set e.g.
> lockscreen - or maybe access control is per-request? This will
> probably
> cause some confusion.

Oh, yes, that's a good part to consider. I feels only tablet-shell this
process could show lockscreen.

> 
> src/tablet-shell.c actually has this comment on creating the
> tablet_shell global object:
> /* FIXME: This will make the object available to all clients. */
> 
> Let's call the generic tablet shell client interface tablet_generic
> for
> this discussion. (All the shell interface names seem to be a little
> out
> of place, starting with wl_shell and desktop_shell.)

We will refine the code structure.

> 
> When a client initialises, the set of advertised global interfaces
> will
> contain either wl_shell or tablet_generic, or at least the client
> should
> bind to only one of the two. If it binds to tablet_generic, if knows
> it
> has to be full-screen always, it doesn't need an event to tell it
> that.
> How does it know what size to make its surface, I don't know. Looking
> at outputs or add a configure event?

Do you mean the client itself should know it was working for
tablet-shell and need some modification?

I think the client should not have to know that, or take some action.
If the client response to the the event tablet-shell send, then it could
do some configuration to it. 
If the client doesn't response, then it could work usually, then
tablet-shell will add a black surface under it, to make it looks like
fullscreen.
In this way, tablet-shell could easy to support the toolkits who don't
add support to tablet-shell, for example efl applications.
Then the application development will feel easy to support both
desktop-shell and tablet-shell.

> 
> The last real changes to the tablet protocol are from May 2011, so I
> think it needs an overhaul.

Agree, let's make it step by step. :)
> 
Thanks,
Juan
> 
> HTH,
> pq