[PATCH 2/9] screenshooter: Report an error if we fail to open the file

Rob Bradford robert.bradford at intel.com
Wed Dec 5 10:47:04 PST 2012


From: Rob Bradford <rob at linux.intel.com>

---
 src/screenshooter.c | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/src/screenshooter.c b/src/screenshooter.c
index 24999f3..840dfb8 100644
--- a/src/screenshooter.c
+++ b/src/screenshooter.c
@@ -404,9 +404,6 @@ weston_recorder_create(struct weston_output *output, const char *filename)
 	recorder->output = output;
 	memset(recorder->frame, 0, size);
 
-	recorder->fd = open(filename,
-			    O_WRONLY | O_CREAT | O_TRUNC | O_CLOEXEC, 0644);
-
 	header.magic = WCAP_HEADER_MAGIC;
 
 	switch (output->compositor->read_format) {
@@ -421,6 +418,14 @@ weston_recorder_create(struct weston_output *output, const char *filename)
 		return;
 	}
 
+	recorder->fd = open(filename,
+			    O_WRONLY | O_CREAT | O_TRUNC | O_CLOEXEC, 0644);
+
+	if (recorder->fd < 0) {
+		weston_log("problem opening output file %s: %m\n", filename);
+		return;
+	}
+
 	header.width = output->current->width;
 	header.height = output->current->height;
 	recorder->total += write(recorder->fd, &header, sizeof header);
-- 
1.7.11.7



More information about the wayland-devel mailing list