[PATCH weston 1/4] tests: write logs to files

[Pekka Paalanen]

On Wed, 12 Dec 2012 10:58:31 -0500
Kristian Høgsberg <hoegsberg at gmail.com> wrote:

> On Wed, Dec 12, 2012 at 02:44:52PM +0200, Pekka Paalanen wrote:
> > On Wed, 12 Dec 2012 14:26:38 +0200
> > Pekka Paalanen <ppaalanen at gmail.com> wrote:
> > 
> > > This cleans up the 'make check' output considerably. When all goes well,
> > > you will only see the "PASS" line for each of $TESTS.
> > > 
> > > Weston logs into a separate file than stdout and stderr, so server logs
> > > end up in one file per test, and other output to another file per test.
> > > 
> > > 'make distclean' does not remove the tests/logs/ directory.
> > > 
> > > Also changes the weston-tests-env interpreter to bash, since I think &>
> > > and ${1/.la/.so} might be bashisms.
> > > ---
...
> 
> Yeah, that fine, we can always tweak it as we go.  All four patches
> committed.  What about cleaning up the logs on make clean?

Patch sent, it was easier that I thought.

> > Have you noticed, that surface-global-test.la and surface-test.la
> > produce:
> > failed to initialize display
> > failed to create display: Broken pipe
> > 
> > Maybe it's a race, where weston-desktop-shell has not started yet, when
> > the server is already done and gone? I guess it's not harmful, just
> > annoying.
> 
> I did see those go by, yes... I think it's because we run the test
> inside weston and shut down before desktop-shell gets to connect.
> Which reminds me, the test suite can run without any shell module,
> which makes a lot of sense in any case.  You have to set
> 
> modules=
> 
> in weston.ini to make that work.

Hmm, so to prevent any custom weston.ini files from affecting the
tests, we would need a command line option to choose a specific
weston.ini alternative, provide a tests-oriented config with the tests,
and use it in weston-tests-env script.

I don't think I'll do that until I need it to fix something harmful.


Thanks,
pq