[protocol v6 PATCH] add maximised protocol

[Rob Bradford]

On 3 February 2012 08:45, Pekka Paalanen <ppaalanen at gmail.com> wrote:
> On Fri,  3 Feb 2012 16:16:16 +0800
> juan.j.zhao at linux.intel.com wrote:
>
>> From: Juan Zhao <juan.j.zhao at linux.intel.com>
>>
>> add a request from the client to notify the compositor the maximised
>> operation. The compositor will send a configure event back to the
>> client
>> ---
>>  protocol/wayland.xml |    8 ++++++++
>>  1 files changed, 8 insertions(+), 0 deletions(-)
>>
>> diff --git a/protocol/wayland.xml b/protocol/wayland.xml
>> index cad2507..805bbd0 100644
>> --- a/protocol/wayland.xml
>> +++ b/protocol/wayland.xml
>> @@ -428,6 +428,14 @@
>>        </description>
>>      </request>
>>
>> +    <request name="set_maximised" >
>> +      <description summary="make the surface a maximised surface">
>> +     A request from the client to notify the compositor the maximised
>> +     operation. The compositor will send a configure event back to the
>> +     client.
>
> I would change the last sentence to: The compositor will reply with a
> configure event telling the expected new surface size. The operation is
> completed on the next buffer attach to this surface.
>
> This should make it obvious to a reader that the client is not supposed
> to guess the proper size on its own.

I think the documentation should further explain what a "maximised
surface" is - what characteristics does it have - how does it differ
from say, fullscreen?

Cheerio,

Rob